Modes

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14999 updated the code based on the alarms table update

  1. … 4 more files in changeset.
Merged DEN-14999

  1. … 4 more files in changeset.
DEN-14999, DEN-15031 added code to receive and support different types of acid and bicarb in the treatment

  1. … 3 more files in changeset.
DEN-13674, DEN-13675 changed the fill mode to be able to restart fill if the acid and bicarb conducitivies are out of range

Merge branch 'staging' into DEN-14999-alarm-table-updates

DEN-14999 added a blank line

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Check the diff of the last two commits.

Check the diff of the last two commits.

What I meant is that we don't need to send anything other than response.

What I meant is that we don't need to send anything other than response.

Done

Done

Remove TODO?

Remove TODO?

DEN-15014 updated the fill mode by removing the enable RO only mode variable from the init function to not be set to FALSE every time

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-15014 addressed the code review comments

  1. … 4 more files in changeset.
Done

Done

Changed it to TRUE/FALSE.

Changed it to TRUE/FALSE.