Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15274 addressed the code review comments

  1. … 2 more files in changeset.
Disagree with comment change.

Disagree with comment change.

Let's put test config conditions last when mixing with normal conditions (both ifs).

Let's put test config conditions last when mixing with normal conditions (both ifs).

Done

Done

Done

Done

Extra blank line.

Extra blank line.

Comment for function.

Comment for function.

DEN-15274, DEN-15246 Added code to not lose the commanded fill volume from HD due to multiple bad fill modes. Updated the heaters code to keep getting the dialysate the flow for the trimmer control. Updated the drain to volume function

  1. … 3 more files in changeset.
DG-DEN-15336_FW Add Framing Error FE And Overrun Error OE TO DG TO Fpga Communications
DG-DEN-15336_FW Add Framing Error FE And Overrun Error OE TO DG TO Fpga Communications
Are these TODOs going to be removed?

Are these TODOs going to be removed?

DG-DEN-15196_DIAL-251
DG-DEN-15196_DIAL-251
Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

DEN-15274 created another function to drain to a target volume in milliliters

  1. … 2 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 4 more files in changeset.
Declarations before code.

Declarations before code.

Merged DEN-15246

  1. … 2 more files in changeset.
Should be != TRUE?

Should be != TRUE?

loadcells[] is an output in this function.

loadcells[] is an output in this function.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Keep going. Now 95 is wrong. Need comments to align with actual values throughout.

Keep going. Now 95 is wrong. Need comments to align with actual values throughout.

Done

Done

Then the one above with 100 comment is wrong.

Then the one above with 100 comment is wrong.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEN-15246 updated the bicarb RO flow from 400 mL/min to 800 mL/min