dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 08 Aug 2023
11:31 am

Michael Garthwaite

code review comments.

Options
    • -1
    • +0
    ./OperationModes.c
11:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:58 am

Sean Nash

Remove blank line.

Remove blank line.

10:45 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:45 am

Sean Nash

Restore blank line below separator comment.

Restore blank line below separator comment.

10:45 am

Sean Nash

Add blank line before separator comment.

Add blank line before separator comment.

10:42 am

Sean Nash

Where is this function being called?

Where is this function being called?

10:38 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:38 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:36 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:35 am

Sean Nash

Add blank line before function header.

Add blank line before function header.

10:27 am

Michael Garthwaite

DEN-15634: code review comments

Options
    • -9
    • +6
    ./ModeDrain.c
10:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

Monday 07 Aug 2023
6:09 pm

wbracken  (deleted user)

These 3 variables are not referenced

These 3 variables are not referenced

6:06 pm

wbracken  (deleted user)

Update header

Update header

6:05 pm

wbracken  (deleted user)

Add dataPublishCounter to header

Add dataPublishCounter to header

6:04 pm

wbracken  (deleted user)

Align comment

Align comment

4:13 pm

Michael Garthwaite

DEN-15634: implemented bad fill signal on fill and drain modes. Implemented drain mode broadcast

Options
    • -2
    • +36
    ./ModeDrain.c
    • -1
    • +7
    ./ModeDrain.h
    • -1
    • +3
    ./ModeFill.c
    • -0
    • +2
    ./ModeFill.h
    • -0
    • +13
    ./ModeGenIdle.c
    • -0
    • +1
    ./ModeGenIdle.h
4:03 pm

Dara Navaei

DG-DEN-15634_Bad Fill States And Signal Updating Inconsistently
DG-DEN-15634_Bad Fill States And Signal Updating Inconsistently
2:20 pm

Michael Garthwaite

DEN-15570: fixed operation status event to be sent after updating currentMode.

Options
    • -2
    • +1
    ./OperationModes.c
8:51 am

Michael Garthwaite

We're starting seeing a trend where V&V want to override pre-calibrated values ( like the LC structure above ). I followed the LC override style since it has similar behavior. I have no issue split...

We're starting seeing a trend where V&V want to override pre-calibrated values ( like the LC structure above ). I followed the LC override style since it has similar behavior. I have no issue splitting

Friday 04 Aug 2023
10:22 am

Sean Nash

This is non-standard override record and approach. Is there any reason why you didn't just create a separate override command and message to override raw flow?

This is non-standard override record and approach. Is there any reason why you didn't just create a separate override command and message to override raw flow?

Thursday 03 Aug 2023
1:21 pm

Sean Nash

12:04 pm

Dara Navaei

DG-DIAL-273_Need Override For Dg.Flow Sensors.Measured Raw Dialysate Flow Lpm
DG-DIAL-273_Need Override For Dg.Flow Sensors.Measured Raw Dialysate Flow Lpm
10:09 am

Dara Navaei

9:51 am

Sean Nash

9:45 am

Dara Navaei and Sean Nash