dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 08 Sep 2023
1:27 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Corrected spacing in the file per CR comments

Options
    • -1
    • +3
    ./ModeFill.c
1:19 pm

Sean Nash

Add blank line between this code and switch below.

Add blank line between this code and switch below.

11:03 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:47 am

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low' into develop

Options
    • -50
    • +24
    ./ModeFill.c
10:42 am

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Follow up for changes, simplifications suggested by Sean.

Options
    • -50
    • +24
    ./ModeFill.c
10:30 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModeFlush.c
    • -1
    • +1
    ./ModeHeatDisinfect.c
10:27 am

Dara Navaei

10:26 am

Michael Garthwaite , wbracken  (deleted user) and Sean Nash

10:23 am

Dara Navaei

DEN-16383 updated the code

Options
    • -1
    • +1
    ./ModeHeatDisinfect.c
9:51 am

jtaylor  (deleted user)

These fields have been moved to a different broadcast at some point, and were no longer being set by the reservoir data broadcast. The fields regularly contained "NAN" values, so I removed them.

These fields have been moved to a different broadcast at some point, and were no longer being set by the reservoir data broadcast. The fields regularly contained "NAN" values, so I removed them.

9:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:12 am

Dara Navaei

DEN-16383 updated mode flush

Options
    • -9
    • +10
    ./ModeFlush.c
    • -2
    • +1
    ./ModeHeatDisinfect.c
9:06 am

Dara Navaei

Why are these fields removed?

Why are these fields removed?

Thursday 07 Sep 2023
6:28 pm

Dara Navaei

DEN-16383 fixed the heat disinfect alarm 242 trigger

Options
    • -3
    • +3
    ./ModeHeatDisinfect.c
6:05 pm

Dara Navaei

DG-DEN-16383_Heat Disinfect R1 TO R2 Timer Overflows And Stuck IN State
DG-DEN-16383_Heat Disinfect R1 TO R2 Timer Overflows And Stuck IN State
3:41 pm

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low' into develop

Options
    • -24
    • +62
    ./ModeFill.c
3:35 pm

jtaylor  (deleted user)

Done. Code updates pushed.

Done. Code updates pushed.

3:34 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Updated headers

Options
    • -1
    • +1
    ./ModeFill.c
3:27 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

fill time allowance for time spent in pause state

Cleared fill timer on transition to generate

Added removed unused (and uninitialized) variables from broadcast data structure.

Options
    • -2
    • +38
    ./ModeFill.c
  2. … 1 more file in changeset.
1:47 pm

Sean Nash

I don't see these being used anywhere.

I don't see these being used anywhere.

1:18 pm

Sean Nash

10:28 am

Dara Navaei

DG Staging Unreviewed Commits
DG Staging Unreviewed Commits
10:25 am

Dara Navaei

10:20 am

wbracken  (deleted user) and Michael Garthwaite

Wednesday 06 Sep 2023
9:07 pm

Dara Navaei

DG-DEN-16381_Chemical Disinfect 1St Transition TO Disinfect R1 TO R2 Lasting Only 50 MS
DG-DEN-16381_Chemical Disinfect 1St Transition TO Disinfect R1 TO R2 Lasting Only 50 MS
9:06 pm

Dara Navaei

DEN-16381 updated the doxygen comment

Options
    • -1
    • +2
    ./ModeChemicalDisinfect.c
9:03 pm

Dara Navaei

DEN-16381 added code to 0 the disinfect timer prior to transitioning to disinfect R1 to R2 for the first time

Options
    • -0
    • +1
    ./ModeChemicalDisinfect.c
4:54 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModeChemicalDisinfect.c
4:53 pm

Dara Navaei

4:41 pm

wbracken  (deleted user) and Michael Garthwaite