dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 18 Sep 2023
8:53 am

Michael Garthwaite

DIAL-285: fix to ensure we see transitions of submode.

Options
    • -0
    • +3
    ./OperationModes.c
Friday 15 Sep 2023
4:39 pm

jtaylor  (deleted user)

4:38 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeFill.c
  2. … 2 more files in changeset.
4:36 pm

Dara Navaei , Sean Nash and wbracken  (deleted user)

4:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:55 pm

jtaylor  (deleted user)

Dara suggested removing this, as the feature was incomplete and appears to cause odd timer/alarm behavior.

Dara suggested removing this, as the feature was incomplete and appears to cause odd timer/alarm behavior.

3:32 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeChemicalDisinfect.c
    • -1
    • +1
    ./ModeHeatDisinfect.c
    • -1
    • +1
    ./ModeStandby.c
    • -2
    • +2
    ./OperationModes.c
    • -2
    • +2
    ./OperationModes.h
  6. … 1 more file in changeset.
3:31 pm

Dara Navaei

2:43 pm

jtaylor  (deleted user) , wbracken  (deleted user) and Sean Nash

8:50 am

Dara Navaei

DEN-15973 updated the chemical disinfect

Options
    • -1
    • +7
    ./ModeChemicalDisinfect.c
Thursday 14 Sep 2023
6:04 pm

Dara Navaei

DEN-15973 updated chem disinfect

Options
    • -1
    • +3
    ./ModeChemicalDisinfect.c
5:37 pm

Dara Navaei

DEN-15973 updated chemical disinfect

Options
    • -1
    • +1
    ./ModeChemicalDisinfect.c
5:01 pm

Dara Navaei

DEN-16432 fixed the heat disinfect temperature out of range trial count error

Options
    • -2
    • +3
    ./ModeHeatDisinfect.c
4:23 pm

Sean Nash

You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?

You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?

4:05 pm

Dara Navaei

DG-DIAL-285_Event Log 15 Missing Fill Prime Concentrate State
DG-DIAL-285_Event Log 15 Missing Fill Prime Concentrate State
3:35 pm

Dara Navaei

DEN-15973 updated the chemical disinfect

Options
    • -2
    • +3
    ./ModeChemicalDisinfect.c
1:26 pm

Dara Navaei

DEN-15973 updated chemical disinfect

Options
    • -1
    • +1
    ./ModeChemicalDisinfect.c
10:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:28 am

Dara Navaei

Done

Done

10:27 am

Dara Navaei

DEN-15973 addressed the code review comments

Options
    • -4
    • +4
    ./ModeStandby.c
9:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

9:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:49 am

Dara Navaei

9:48 am

Dara Navaei

DEN-15973 addressed the code review comments

Options
    • -1
    • +5
    ./ModeStandby.c
    • -1
    • +1
    ./OperationModes.h
  3. … 1 more file in changeset.
9:44 am

Dara Navaei

Done

Done

9:42 am

Dara Navaei

Done

Done

9:38 am

Sean Nash

You at least need to add a comment explaining what they are.

You at least need to add a comment explaining what they are.

9:38 am

Dara Navaei

Done

Done