dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 28 Sep 2023
8:56 am

Dara Navaei

DEN-16446 addressed the code review comment

Options
    • -1
    • +4
    ./ModeHeatDisinfect.c
8:33 am

Dara Navaei

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

8:31 am

Dara Navaei

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp o...

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

Wednesday 27 Sep 2023
4:40 pm

jtaylor  (deleted user)

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even ...

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

3:32 pm

Dara Navaei

DEN-16446 updated the code for VectorCAST

Options
    • -1
    • +1
    ./ModeFill.c
    • -1
    • +3
    ./ModeHeatDisinfect.c
1:07 pm

Sean Nash

What's left? When would this code ever become reachable?

What's left? When would this code ever become reachable?

8:57 am

Dara Navaei

DEN-16446 updated the code and VectorCAST test cases

Options
    • -1
    • +5
    ./ModeFill.c
8:30 am

jtaylor  (deleted user)

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

Monday 25 Sep 2023
2:55 pm

Dara Navaei

DEN-16446 updated the code based on the VectorCAST tests

Options
    • -7
    • +7
    ./ModeChemicalDisinfect.c
Sunday 24 Sep 2023
1:36 pm

Dara Navaei

DEN-16446 updated the code and the VectorCAST test cases

Options
    • -1
    • +2
    ./ModeChemicalDisinfect.c
11:02 am

Sean Nash

DEN-15791: Doxygen comment fixes.

Options
    • -1
    • +1
    ./ModeDrain.c
    • -5
    • +7
    ./ModeFill.c
    • -2
    • +2
    ./ModeGenIdle.c
    • -1
    • +0
    ./OperationModes.c
  5. … 2 more files in changeset.
Wednesday 20 Sep 2023
1:59 pm

Dara Navaei

DEN-16446 added string.h for memset

Options
    • -0
    • +2
    ./ModeChemicalDisinfect.c
1:57 pm

Dara Navaei

Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

Options
    • -4
    • +4
    ./ModeFill.c
1:55 pm

Dara Navaei

Merged staging

Options
    • -2
    • +2
    ./ModeDrain.c
1:47 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeDrain.c
    • -1
    • +1
    ./ModeFill.c
    • -2
    • +2
    ./ModeFill.h
    • -2
    • +2
    ./ModeGenIdle.c
1:30 pm

Dara Navaei

1:26 pm

wbracken  (deleted user) and Sean Nash

9:53 am

Dara Navaei

Merge branch 'staging' into DEN-16382-alarm-207-dg-flow-meter-check-failure-triggers-after-alarm-282-bicarbonate-volume

Options
    • -6
    • +8
    ./ModeFill.c
9:12 am

Dara Navaei

DEN-16446 updated the code for VectorCAST

Options
    • -1
    • +1
    ./ModeFill.c
  2. … 1 more file in changeset.
Tuesday 19 Sep 2023
4:18 pm

Michael Garthwaite

2:07 pm

Dara Navaei

DG-DEN-16446_DG Dev Test Clean UP
DG-DEN-16446_DG Dev Test Clean UP
1:29 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeFill.c
1:21 pm

Dara Navaei

Merge branch 'DEN-16382-alarm-207-dg-flow-meter-check-failure-triggers-after-alarm-282-bicarbonate-volume' into develop

Options
    • -2
    • +2
    ./ModeDrain.c
    • -2
    • +2
    ./ModeFill.c
1:18 pm

Dara Navaei

1:12 pm

Dara Navaei

DEN-16382 updated the code to eliminate the extra fill command after the empty bottles alarm

Options
    • -2
    • +2
    ./ModeDrain.c
    • -2
    • +2
    ./ModeFill.c
    • -1
    • +1
    ./ModeFill.h
    • -8
    • +0
    ./ModeGenIdle.c
11:40 am

Sean Nash

11:33 am

Dara Navaei

11:33 am

Dara Navaei

11:20 am

Dara Navaei

Merge branch 'DEN-16314-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low-2' into develop

Options
    • -4
    • +6
    ./ModeFill.c
11:19 am

Dara Navaei

DEN-16314 added code in the fill mode to set the start fill time if it was 0 even if the previous state in the fill mode was pause

Options
    • -4
    • +6
    ./ModeFill.c