Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done

Done

It is an input - don't remove flag there. It is not an output - so remove it there.

It is an input - don't remove flag there. It is not an output - so remove it there.

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I don't see the flag being set in this function.

I don't see the flag being set in this function.

Why are we keeping these in the broadcast?

Why are we keeping these in the broadcast?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

Should you do something with the received max ratio? It's local, so it's just being dropped.

Should you do something with the received max ratio? It's local, so it's just being dropped.

max ratio

max ratio

DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging
DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging
DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

I used fabs so all are positive when monitoring is started.

I used fabs so all are positive when monitoring is started.

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging
DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging