dgfirmware / firmware / App / Services

FPGA.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Sep 2022
3:07 pm

Dong Nguyen <dnguyen@diality.com>

DEN-13598: Removed test code and comments.

Options
    • -2
    • +2
    ./FPGA.c
  2. … 1 more file in changeset.
11:27 am

Sean Nash

Remove comment at end of line.

Remove comment at end of line.

11:26 am

Sean Nash

Indent here looks smaller than others. Should be 4 spaces.

Indent here looks smaller than others. Should be 4 spaces.

11:25 am

Sean Nash

Initialize these in init function below (like other variables).

Initialize these in init function below (like other variables).

11:25 am

Sean Nash

Align these with first 2 #defines.

Align these with first 2 #defines.

11:05 am

Sean Nash

Move this to after execHeaters() and before #endif.

Move this to after execHeaters() and before #endif.

11:01 am

Sean Nash

Remove comment at end of line.

Remove comment at end of line.

10:58 am

Sean Nash

Please restore to normal return value and remove comments.

Please restore to normal return value and remove comments.

10:57 am

Sean Nash

Remove blank line.

Remove blank line.

10:56 am

Sean Nash

Remove this extra blank line.

Remove this extra blank line.

10:55 am

Sean Nash

Not sure why this code is here - comment says remove so please remove these 2 lines of code.

Not sure why this code is here - comment says remove so please remove these 2 lines of code.

10:46 am

Sean Nash

I think idea here is that we don't want any process to hold onto semaphore for very long so it can't block other processes for too long. If another process is calling this function to try to access...

I think idea here is that we don't want any process to hold onto semaphore for very long so it can't block other processes for too long. If another process is calling this function to try to access the protected resource, it will check for timeout and alarm if semaphore has been held for too long.

10:33 am

Sean Nash

Need a default and s/w fault for this switch statement.

Need a default and s/w fault for this switch statement.

10:13 am

Sean Nash

Keep this blank line.

Keep this blank line.

9:32 am

Sean Nash

DEN-13598: Removed test code and comments.

Options
    • -10
    • +6
    ./FPGA.c
9:13 am

Sean Nash

Should default trigger a s/w fault?

Should default trigger a s/w fault?

9:09 am

Sean Nash

This default is unreachable I think.

This default is unreachable I think.

Tuesday 20 Sep 2022
5:47 pm

wbracken  (deleted user)

No inputs.

No inputs.

5:43 pm

wbracken  (deleted user)

Should 100.0 be a #define?

Should 100.0 be a #define?

5:41 pm

wbracken  (deleted user)

Does this actually work?

Does this actually work?

5:27 pm

Dong Nguyen <dnguyen@diality.com>

DEN-13598: Changed DG FPGA timer accuracy check to be time windowed count type alarm.

Options
    • -19
    • +4
    ./FPGA.c
  2. … 6 more files in changeset.
10:22 am

Sean Nash

Restore this blank line.

Restore this blank line.

10:21 am

Sean Nash

This is legal, but odd looking. Can we define this structure type at top of module and have a normal declaration for baroCoeffs here?

This is legal, but odd looking. Can we define this structure type at top of module and have a normal declaration for baroCoeffs here?

10:19 am

Sean Nash

Can we add a comment explaining why these temp sensors are monitored and the rest are ignored?

Can we add a comment explaining why these temp sensors are monitored and the rest are ignored?

10:16 am

Sean Nash

Add blank line between declaration and code.

Add blank line between declaration and code.

8:59 am

Dong Nguyen

Already uncommented.

Already uncommented.

8:57 am

Sean Nash

Keep blank line.

Keep blank line.

8:51 am

Dong Nguyen

Already removed the marge markers.

Already removed the marge markers.

8:50 am

Dong Nguyen

Already removed marge markers.

Already removed marge markers.

Monday 19 Sep 2022
3:10 pm

Darren Cox

F32 needs 0.0F init value.

F32 needs 0.0F init value.