Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-13598: Removed test code and comments.

  1. … 1 more file in changeset.
Remove comment at end of line.

Remove comment at end of line.

Indent here looks smaller than others. Should be 4 spaces.

Indent here looks smaller than others. Should be 4 spaces.

Initialize these in init function below (like other variables).

Initialize these in init function below (like other variables).

Align these with first 2 #defines.

Align these with first 2 #defines.

Move this to after execHeaters() and before #endif.

Move this to after execHeaters() and before #endif.

Remove comment at end of line.

Remove comment at end of line.

Please restore to normal return value and remove comments.

Please restore to normal return value and remove comments.

Remove blank line.

Remove blank line.

Remove this extra blank line.

Remove this extra blank line.

Not sure why this code is here - comment says remove so please remove these 2 lines of code.

Not sure why this code is here - comment says remove so please remove these 2 lines of code.

I think idea here is that we don't want any process to hold onto semaphore for very long so it can't block other processes for too long. If another process is calling this function to try to access...

I think idea here is that we don't want any process to hold onto semaphore for very long so it can't block other processes for too long. If another process is calling this function to try to access the protected resource, it will check for timeout and alarm if semaphore has been held for too long.

Need a default and s/w fault for this switch statement.

Need a default and s/w fault for this switch statement.

Keep this blank line.

Keep this blank line.

DEN-13598: Removed test code and comments.

Should default trigger a s/w fault?

Should default trigger a s/w fault?

This default is unreachable I think.

This default is unreachable I think.

No inputs.

No inputs.

Should 100.0 be a #define?

Should 100.0 be a #define?

Does this actually work?

Does this actually work?

DEN-13598: Changed DG FPGA timer accuracy check to be time windowed count type alarm.

  1. … 6 more files in changeset.
Restore this blank line.

Restore this blank line.

This is legal, but odd looking. Can we define this structure type at top of module and have a normal declaration for baroCoeffs here?

This is legal, but odd looking. Can we define this structure type at top of module and have a normal declaration for baroCoeffs here?

Can we add a comment explaining why these temp sensors are monitored and the rest are ignored?

Can we add a comment explaining why these temp sensors are monitored and the rest are ignored?

Add blank line between declaration and code.

Add blank line between declaration and code.

Already uncommented.

Already uncommented.

Keep blank line.

Keep blank line.

Already removed the marge markers.

Already removed the marge markers.

Already removed marge markers.

Already removed marge markers.

F32 needs 0.0F init value.

F32 needs 0.0F init value.