Integrity.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Good point. The module has been moved to fwcommon.

Good point. The module has been moved to fwcommon.

Removed the wrapper function. For now, only support one type of 32-bit CRC algorithm.

Removed the wrapper function. For now, only support one type of 32-bit CRC algorithm.

Done.

Done.

Noe said they updated the ID and this is the new ID for DG FPGA. The FPGA test will fail without this change.

Noe said they updated the ID and this is the new ID for DG FPGA.
The FPGA test will fail without this change.

Should mention somewhere that timer is counting ms.

Should mention somewhere that timer is counting ms.

Why did this change?

Why did this change?

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The only preference is to put TRUE first if it is == such as below.

The only preference is to put TRUE first if it is == such as below.

Should we move this enum to separate .h file?

Should we move this enum to separate .h file?

Place TRUE as first argument.

Place TRUE as first argument.

DG-DEN-8103_DG HD Dev Alarm Design
DG-DEN-8103_DG HD Dev Alarm Design