MsgQueues.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 100 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 100 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 100 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 100 more files in changeset.
RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

DG-DEN-4217_Level and Shock Detection
DG-DEN-4217_Level and Shock Detection
DG Staging Unreviewed Commits
DG Staging Unreviewed Commits
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 98 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 94 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 92 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Good catch, it is actually an unintended L. Removed.

Good catch, it is actually an unintended L. Removed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Pumps are now controlled individually. Reverse direction for motor has been added.

Pumps are now controlled individually. Reverse direction for motor has been added.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not a big fan of numbering variables like Speed1, Speed2, etc.

Not a big fan of numbering variables like Speed1, Speed2, etc.

There may be a need to run these pumps in forward or reverse direction (heat disinfect mode). And this would not be tied to RO flow rate - we would want to set an independent flow. May also want to...

There may be a need to run these pumps in forward or reverse direction (heat disinfect mode). And this would not be tied to RO flow rate - we would want to set an independent flow. May also want to control the pumps independently in this mode.

This was responsible for turn off concentrate pumps when HD commands DG to exit out of fill mode, but reservoir module has handled this.

This was responsible for turn off concentrate pumps when HD commands DG to exit out of fill mode, but reservoir module has handled this.

It was acting as a function to turn off concentrate pump if HD commands DG exits fill mode, but has been removed due to reservoir module will handle this.

It was acting as a function to turn off concentrate pump if HD commands DG exits fill mode, but has been removed due to reservoir module will handle this.

We should think about this. I'm ok with adding an explicit transition out handler (similar to the existing transition to handler), but if we do this we should build this into all modes (DG and HD)....

We should think about this. I'm ok with adding an explicit transition out handler (similar to the existing transition to handler), but if we do this we should build this into all modes (DG and HD).
To date, I've not required any clean-up on way out of a mode - mode can be reset on next entry. That seems to have been working so far.
Valve positions and motor states should be set as appropriate on entry to next mode, so we shouldn't have to worry about these kind of things on way out of a mode.

I don't see this function actually exiting the mode. Is it caller's responsibility to return to re-circ mode after calling this function?

I don't see this function actually exiting the mode. Is it caller's responsibility to return to re-circ mode after calling this function?