dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 26 Jul 2022
4:01 pm

Dara Navaei

DEN-13460 updated the heaters with the latest primary heater gain check

Options
    • -0
    • +1
    ./Reservoirs.c
  2. … 5 more files in changeset.
Sunday 24 Jul 2022
6:38 pm

Dara Navaei

DEN-13460 updated the latest DVT changes and the primary heater gain calculations

Options
    • -8
    • +8
    ./FPGA.c
  2. … 2 more files in changeset.
Saturday 23 Jul 2022
2:46 pm

Sean Nash

Should 0.5 be a #define?

Should 0.5 be a #define?

2:45 pm

Sean Nash

TODO should be all CAPS.

TODO should be all CAPS.

2:43 pm

Sean Nash

Is it really true that all function below this line are DVT?

Is it really true that all function below this line are DVT?

2:42 pm

Sean Nash

If these comment outs are not permanent, add a TODO. Otherwise remove the commented out code.

If these comment outs are not permanent, add a TODO. Otherwise remove the commented out code.

2:37 pm

Sean Nash

Is this logic right? Looks like it should be || instead of && and it should be == instead of != DG_MODE_INIT.

Is this logic right? Looks like it should be || instead of && and it should be == instead of != DG_MODE_INIT.

2:35 pm

Sean Nash

No point in initializing here - gets set by exec function.

No point in initializing here - gets set by exec function.

2:29 pm

Sean Nash

Is this a TODO?

Is this a TODO?

2:26 pm

Sean Nash

Fix alignment.

Fix alignment.

2:25 pm

Sean Nash

Fix alignment.

Fix alignment.

2:24 pm

Sean Nash

Should go to NV data POST state regardless of RTC pass/fail. Still need to get calibration and system records read.

Should go to NV data POST state regardless of RTC pass/fail. Still need to get calibration and system records read.

1:52 pm

Sean Nash

Keep this blank line.

Keep this blank line.

1:51 pm

Sean Nash

Magic number.

Magic number.

1:51 pm

Sean Nash

Keep this blank line.

Keep this blank line.

1:50 pm

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

1:50 pm

Sean Nash

Add comments like others.

Add comments like others.

1:49 pm

Sean Nash

DVT software configuration?

DVT software configuration?

1:46 pm

Sean Nash

Keep this blank line.

Keep this blank line.

1:45 pm

Sean Nash

Flow rate is F32 so change 0 to 0.0F.

Flow rate is F32 so change 0 to 0.0F.

1:42 pm

Sean Nash

Fix alignment.

Fix alignment.

1:37 pm

Sean Nash

Why are these commented out. I thought these were fixed now.

Why are these commented out. I thought these were fixed now.

1:36 pm

Sean Nash

Keep this blank line.

Keep this blank line.

1:35 pm

Sean Nash

You can just use 0.0F here.

You can just use 0.0F here.

1:34 pm

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

Friday 22 Jul 2022
10:37 am

Sean Nash

Should be s/w fault. Add TODO or trigger s/w fault now.

Should be s/w fault. Add TODO or trigger s/w fault now.

10:36 am

Sean Nash

Blank line between declarations and code.

Blank line between declarations and code.

10:34 am

Sean Nash

This assignment should be done above at declaration. Move calStatus declaration above result.

This assignment should be done above at declaration. Move calStatus declaration above result.

10:31 am

Sean Nash

Keep this blank line.

Keep this blank line.

10:17 am

Sean Nash

Do either of these 2 if statements need an else?

Do either of these 2 if statements need an else?