Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-13460 updated the code with the DVT changes

  1. … 7 more files in changeset.
Does the monitorPumpSpeed function generate the alarm

Does the monitorPumpSpeed function generate the alarm

DEN-13460: fixed merge conflicts.

DEN-13460: Handle request to re-send active alarms.

DEN-13460 Implemented FAULT LED and Audio control in AlarmMgmt.c.

Merge branch 'DEN-13427-sw_dev-sprint-75_mg' into develop

DEN-13427: Errors and warnings fixes

Complication Fix

DEN-13427: DG Service Mode deenergizes and can Fault

Service Mode deenergizes actuators when we enter the mode. Fault is raised in Service Mode if we get a submode out of range.

  1. … 2 more files in changeset.
DEN-13427: Message handler and response for DG's request to service mode

DEN-13460: If HD commands stop fill, clear bad fill flag in gen idle mode so we don't get stuck there.

Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' into develop

  1. … 2 more files in changeset.
DEN-13460 updated the heaters with the latest primary heater gain check

  1. … 5 more files in changeset.
DEN-13460 updated the latest DVT changes and the primary heater gain calculations

  1. … 2 more files in changeset.
Should 0.5 be a #define?

Should 0.5 be a #define?

TODO should be all CAPS.

TODO should be all CAPS.

Is it really true that all function below this line are DVT?

Is it really true that all function below this line are DVT?

If these comment outs are not permanent, add a TODO. Otherwise remove the commented out code.

If these comment outs are not permanent, add a TODO. Otherwise remove the commented out code.

Is this logic right? Looks like it should be || instead of && and it should be == instead of != DG_MODE_INIT.

Is this logic right? Looks like it should be || instead of && and it should be == instead of != DG_MODE_INIT.

No point in initializing here - gets set by exec function.

No point in initializing here - gets set by exec function.

Is this a TODO?

Is this a TODO?

Fix alignment.

Fix alignment.

Fix alignment.

Fix alignment.

Should go to NV data POST state regardless of RTC pass/fail. Still need to get calibration and system records read.

Should go to NV data POST state regardless of RTC pass/fail. Still need to get calibration and system records read.

Keep this blank line.

Keep this blank line.

Magic number.

Magic number.

Keep this blank line.

Keep this blank line.

Add blank line between declarations and code.

Add blank line between declarations and code.

Add comments like others.

Add comments like others.

DVT software configuration?

DVT software configuration?

Keep this blank line.

Keep this blank line.