Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14197: Addressed code review comments.

  1. … 4 more files in changeset.
Remove extra blank line.

Remove extra blank line.

Update header.

Update header.

Update header.

Update header.

Testers requested the feature as feed back voltage. see http://dvm-linux02:8080/browse/DIAL-212 The static variable name is roPumpFeedbackDutyCyclePct. We get data from the INT_ADC_RO_PUMP_FEEDBAC...

Testers requested the feature as feed back voltage. see http://dvm-linux02:8080/browse/DIAL-212

The static variable name is roPumpFeedbackDutyCyclePct. We get data from the INT_ADC_RO_PUMP_FEEDBACK_DUTY_CYCLE register on the FPGA in execROPumpMonitor/

No issue renaming it but is it a voltage or a duty cycle?

Remove

Remove

Alignment

Alignment

Remove

Remove

Alignment

Alignment

Alignment

Alignment

Alignment and commented out code.

Alignment and commented out code.

Needs function header.

Needs function header.

Alignment

Alignment

Alignment

Alignment

Alignment

Alignment

Alignment

Alignment

Alignment

Alignment

Alignment

Alignment

Remove.

Remove.

Alignment

Alignment

Remove commented code.

Remove commented code.

Alignment

Alignment

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

I think it's abbreviated - should be spelled out (inactiveReservoir) I think.

I think it's abbreviated - should be spelled out (inactiveReservoir) I think.

If it's a global static variable, use variable name. If it's accessed via another module's get function, description is ok.

If it's a global static variable, use variable name. If it's accessed via another module's get function, description is ok.

Add another blank line here (separates normal code from test code).

Add another blank line here (separates normal code from test code).

Alignment.

Alignment.

Alignment

Alignment

Alignment

Alignment