Services

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14999: Small fix to DG WD POST.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Merged DEN-14999

  1. … 3 more files in changeset.
I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Updates to hold off processing retries until after INIT, and after communication with HD started.

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-14999-alarm-table-updates

Fixed handling of HD cmd to change DG reservoir valve config.

DEN-14999, DEN-15030 updated the start DG command function

DEN-14999, DEN-15031 added code to receive and support different types of acid and bicarb in the treatment

  1. … 3 more files in changeset.
No need to increase this one.

No need to increase this one.

DEN-14999 merged the remote changes and updated the fill mode with the acid conductivity values

  1. … 1 more file in changeset.
I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Added a space.

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Increased MSG ACK timeouts. Delayed expecting ACKs until HD turns on and is sending messages.

DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen
DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen
Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Corrected

Corrected

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

DEN-15014 addressed the code review comment

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Check the diff of the last two commits.

Check the diff of the last two commits.

What I meant is that we don't need to send anything other than response.

What I meant is that we don't need to send anything other than response.

Done

Done