dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Mar 2023
12:30 pm

James Walter Taylor <jtaylor@diality.com>

DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Update for code review.

Options
    • -1
    • +1
    ./SystemComm.c
12:29 pm

jtaylor  (deleted user)

Done.

Done.

10:07 am

wbracken  (deleted user)

Space between ((

Space between ((

9:14 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:03 am

Sean Nash

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

8:59 am

James Walter Taylor <jtaylor@diality.com>

HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Closing code review comments.

Options
    • -9
    • +7
    ./SystemComm.c
8:54 am

Michael Garthwaite

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

8:36 am

jtaylor  (deleted user)

Done. Does HD communicating always account for UI traffic as well?

Done. Does HD communicating always account for UI traffic as well?

8:35 am

jtaylor  (deleted user)

Done

Done

8:22 am

jtaylor  (deleted user)

Reverted.

Reverted.

Thursday 30 Mar 2023
9:18 pm

Sean Nash

DEN-14999: Small fix to DG WD POST.

Options
    • -0
    • +5
    ./WatchdogMgmt.c
7:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:04 pm

Dara Navaei

Merged DEN-14999

Options
    • -1
    • +5
    ./SystemComm.c
    • -9
    • +113
    ./SystemCommMessages.c
    • -1
    • +14
    ./SystemCommMessages.h
  4. … 3 more files in changeset.
6:58 pm

Sean Nash

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

6:57 pm

Sean Nash

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

5:56 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Updates to hold off processing retries until after INIT, and after communication with HD started.

Options
    • -7
    • +20
    ./SystemComm.c
5:11 pm

Sean Nash

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-14999-alarm-table-updates

Options
    • -5
    • +5
    ./SystemCommMessages.c
5:11 pm

Sean Nash

Fixed handling of HD cmd to change DG reservoir valve config.

Options
    • -2
    • +2
    ./SystemCommMessages.c
5:10 pm

Dara Navaei

DEN-14999, DEN-15030 updated the start DG command function

Options
    • -5
    • +5
    ./SystemCommMessages.c
2:37 pm

Dara Navaei

DEN-14999, DEN-15031 added code to receive and support different types of acid and bicarb in the treatment

Options
    • -0
    • +18
    ./Reservoirs.c
    • -0
    • +1
    ./Reservoirs.h
    • -5
    • +7
    ./SystemCommMessages.c
  4. … 3 more files in changeset.
2:26 pm

Sean Nash

No need to increase this one.

No need to increase this one.

11:35 am

Dara Navaei

DEN-14999 merged the remote changes and updated the fill mode with the acid conductivity values

Options
    • -0
    • +1
    ./Reservoirs.c
  2. … 1 more file in changeset.
11:35 am

Sean Nash

I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

8:19 am

James Walter Taylor <jtaylor@diality.com>

DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Added a space.

Options
    • -1
    • +1
    ./SystemComm.c
Wednesday 29 Mar 2023
4:10 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Increased MSG ACK timeouts. Delayed expecting ACKs until HD turns on and is sending messages.

Options
    • -19
    • +22
    ./SystemComm.c
4:01 pm

Dara Navaei

DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen
DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen
2:52 pm

Sean Nash

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

11:25 am

wbracken  (deleted user)

Corrected

Corrected

8:39 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./SystemComm.c
    • -1
    • +1
    ./SystemCommMessages.c
    • -1
    • +1
    ./SystemCommMessages.h
  4. … 5 more files in changeset.
8:37 am

Dara Navaei