dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 29 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 26 Apr 2023
8:22 am

Dara Navaei

DEN-15199 added to code to check for dialin check in

Options
    • -0
    • +18
    ./SystemComm.c
    • -2
    • +80
    ./SystemCommMessages.c
    • -0
    • +10
    ./SystemCommMessages.h
  4. … 3 more files in changeset.
Monday 24 Apr 2023
12:40 pm

Dara Navaei

Done

Done

12:40 pm

Dara Navaei

Done

Done

10:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:01 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:01 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

Not a Dialin command. Called by opmodes in firmware.

Not a Dialin command. Called by opmodes in firmware.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:51 am

Sean Nash

Yes, as this function could be called from somewhere other than message handler. RESOLVED in CODE WALKTHROUGH.

Yes, as this function could be called from somewhere other than message handler.
RESOLVED in CODE WALKTHROUGH.

9:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:45 am

Sean Nash

Still want check for logged in.

Still want check for logged in.

9:42 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:15 am

Dara Navaei

DEN-15199 addressed the code review comments

Options
    • -0
    • +1
    ./AlarmMgmtSWFaults.h
  2. … 1 more file in changeset.
9:14 am

Dara Navaei

Done.

Done.

9:13 am

Dara Navaei

Done.

Done.

Friday 21 Apr 2023
2:59 pm

Dara Navaei

Done

Done

2:46 pm

Dara Navaei

Correct. This common code in between the two stacks. I can separate them using #ifndef.

Correct. This common code in between the two stacks. I can separate them using #ifndef.

2:45 pm

Dara Navaei

Done

Done

2:45 pm

Dara Navaei

Done

Done

2:45 pm

Dara Navaei

I removed the memset macro.

I removed the memset macro.

2:44 pm

Dara Navaei

This function will not even be called if Dialin is not logged in. Did you want to check it here too?

This function will not even be called if Dialin is not logged in. Did you want to check it here too?

2:43 pm

Dara Navaei

Done

Done

2:43 pm

Dara Navaei

Done

Done

2:39 pm

Dara Navaei

This function is a Dialin command so it will not even be called if Dialin is not logged in. Did you want to check this again in this function?

This function is a Dialin command so it will not even be called if Dialin is not logged in. Did you want to check this again in this function?

11:41 am

Sean Nash

Note in brief that function will return FALSE if Dialin not logged in.

Note in brief that function will return FALSE if Dialin not logged in.

11:40 am

Sean Nash

testConfig is an input, not an output.

testConfig is an input, not an output.