dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 26 Apr 2023
8:55 am

Dara Navaei

DEN-15199 addressed the code review comments

Options
    • -1
    • +1
    ./SystemComm.c
    • -4
    • +7
    ./SystemCommMessages.c
8:52 am

Dara Navaei

Done

Done

8:50 am

Dara Navaei

Done

Done

8:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:49 am

Dara Navaei

Done

Done

8:49 am

Dara Navaei

Done.

Done.

8:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:42 am

Dara Navaei

Brought the code back.

Brought the code back.

8:41 am

Sean Nash

Why did we blank title/instructions?

Why did we blank title/instructions?

8:38 am

Sean Nash

Acking even if payload length > 0?

Acking even if payload length > 0?

8:36 am

Sean Nash

Checking for isTestingActivated should be done in sendTestConfigStatusToDialin function (not here). Fix throughout new handlers.

Checking for isTestingActivated should be done in sendTestConfigStatusToDialin function (not here). Fix throughout new handlers.

8:33 am

Sean Nash

This is an output.

This is an output.

8:33 am

Sean Nash

Remove "Been" from function name. And add a comment line above explaining what we're doing here.

Remove "Been" from function name. And add a comment line above explaining what we're doing here.

8:22 am

Dara Navaei

DEN-15199 added to code to check for dialin check in

Options
    • -0
    • +18
    ./SystemComm.c
    • -2
    • +80
    ./SystemCommMessages.c
    • -0
    • +10
    ./SystemCommMessages.h
  4. … 3 more files in changeset.
Monday 24 Apr 2023
12:40 pm

Dara Navaei

Done

Done

12:40 pm

Dara Navaei

Done

Done

10:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:01 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:01 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

Not a Dialin command. Called by opmodes in firmware.

Not a Dialin command. Called by opmodes in firmware.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:51 am

Sean Nash

Yes, as this function could be called from somewhere other than message handler. RESOLVED in CODE WALKTHROUGH.

Yes, as this function could be called from somewhere other than message handler.
RESOLVED in CODE WALKTHROUGH.

9:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:45 am

Sean Nash

Still want check for logged in.

Still want check for logged in.

9:42 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:15 am

Dara Navaei

DEN-15199 addressed the code review comments

Options
    • -0
    • +1
    ./AlarmMgmtSWFaults.h
  2. … 1 more file in changeset.