Services

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'staging' into DEN-15660-test_configuration_treatment_recovery

  1. … 4 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

TRo needs comment for doxygen.

TRo needs comment for doxygen.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Nelson is not part of the commercial code.

Nelson is not part of the commercial code.

Done

Done

Done

Done

Done

Done

Nelson support is only in debug mode.

Nelson support is only in debug mode.

Done

Done

Done

Done

The un-averaged TDi and TRo are used for dialysate temperature checking and trimmer heater control I think we should keep them to be able to have a full picture if needed unless the CAN bus is real...

The un-averaged TDi and TRo are used for dialysate temperature checking and trimmer heater control I think we should keep them to be able to have a full picture if needed unless the CAN bus is really flooded.

This is a time and not timeout.

This is a time and not timeout.

Done

Done

Done

Done

Done

Done

Done

Done

handleEmptyBottleFlag is only an input

handleEmptyBottleFlag is only an input

What about acid?

What about acid?

This looks strange. If we have a empty bottle alarm, shouldn't we just not start a fill in the first place? With this approach, you're just stuck in fill start state until user clears the alarm.

This looks strange. If we have a empty bottle alarm, shouldn't we just not start a fill in the first place?
With this approach, you're just stuck in fill start state until user clears the alarm.

Can we move these declarations up to top of scope?

Can we move these declarations up to top of scope?

Replace "TIMEOUT" with "TIME"

Replace "TIMEOUT" with "TIME"

Is this really a timeout? Or is it a minimum duration?

Is this really a timeout? Or is it a minimum duration?

Do we still want un-averaged TDi and TRo in this broadcast? Is anybody using them? If not, why not replace the old temps with the new averages?

Do we still want un-averaged TDi and TRo in this broadcast? Is anybody using them? If not, why not replace the old temps with the new averages?

Swap first and TRo positions in enum. TRo should be first, then we add a first to mark it as first.

Swap first and TRo positions in enum. TRo should be first, then we add a first to mark it as first.