Activity dgfirmware/firmware/App/Services

8:15 am

Michael Garthwaite

More
cfcb924
changed 2 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 87 more

Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

- -5
- +2
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 1 more file in changeset.

8:13 am

Michael Garthwaite

More
DG-DEN-15634-1
Closed

5:50 pm

wbracken (deleted user) and Sean Nash

More
DG-DEN-15634-1
finished reviewing

5:36 pm

Dara Navaei

More
8ebab81
changed 8 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 87 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 7 more files in changeset.

5:29 pm

Dara Navaei

More
DG-DEN-16125-1
Closed

5:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

4:59 pm

wbracken (deleted user) and Sean Nash

More
DG-DEN-16125-1
finished reviewing

4:55 pm

wbracken (deleted user)

More
Re: DG-DENBUG-59-1
replied to Sean Nash

That's what it looked like when reviewed HD side. RESOLVED IN CODE WALKTHROUGH

That's what it looked like when reviewed HD side.

RESOLVED IN CODE WALKTHROUGH

4:25 pm

Michael Garthwaite

More
3a2b4f4
changed 1 file
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 87 more DG-DEN-15634-1

Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

- -7
- +14
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c

4:22 pm

Michael Garthwaite

More
Re: DG-DEN-15634-1
replied to Sean Nash

Fixed!

3:10 pm

Sean Nash

More
Re: DG-DENBUG-59-1
replied to wbracken (deleted user)

For DG, it's not used (yet at least). But there are common macros that call this function, so had to change HD and DG versions of this function.

3:07 pm

Sean Nash

More
Re: DG-DEN-15634-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

3:05 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

3:05 pm

Sean Nash

Move blank line up one.

3:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

3:03 pm

Sean Nash

Move blank line down one.

1:48 pm

wbracken (deleted user)

More
Re: DG-DENBUG-59-1
commented on review

Where is outside used?

1:43 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

1:33 pm

Dara Navaei

More
e7456f2
changed 3 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 88 more DG-DEN-16125-1

DEN-15125 addressed the compiler warnings

- -3
- +0
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 2 more files in changeset.

1:16 pm

Michael Garthwaite

More
46d5a77
changed 3 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 87 more DG-DEN-15634-1

DEN-15634: fixed warnings

- -0
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -0
- +3
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
… 1 more file in changeset.

12:42 pm

Dara Navaei

More
DG-DEN-16125-1
started review

DG-DEN-16125_DG Chem Flush DG Does Not Transition From Flush R1 TO R2 Drain R2 TO Cancel Water

10:32 am

Sean Nash

More
ac8b318
changed 2 files
develop

Merge branch 'DENBUG-59-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow' into develop

- -1
- +2
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -3
- +0
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c

10:30 am

Sean Nash

More
f3929ca
changed 2 files
master, DEN-14706-can-messge-not-acked-fix and 76 more DG-DENBUG-59-1

DENBUG-59: Distinguish between alarms originating outside.

- -3
- +4
./AlarmMgmt.c
- History
- Source
- Diff
./AlarmMgmt.c
- -1
- +1
./AlarmMgmt.h
- History
- Source
- Diff
./AlarmMgmt.h

4:30 pm

Sean Nash

More
821d160
changed 3 files
master, DEN-14706-can-messge-not-acked-fix and 76 more DG-DENBUG-59-1

DENBUG-59: Added alarm properties to prevent alarm trigger while in rinseback or post-tx states.

- -6
- +16
./AlarmMgmt.c
- History
- Source
- Diff
./AlarmMgmt.c
- -1
- +2
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -3
- +0
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c

2:14 pm

Dara Navaei

More
DG-DENBUG-59-1
started review

DG-DENBUG-59_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow

1:38 pm

Dara Navaei

More
5fc30ce
changed 4 files
master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 88 more DG-DEN-15634-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 3 more files in changeset.

1:35 pm

Michael Garthwaite

More
Re: DG-DEN-15634-1
replied to wbracken (deleted user)

Fixed. Thanks!

1:34 pm

Michael Garthwaite

More
DG-DIAL-273-1
Closed

1:26 pm

wbracken (deleted user) and Sean Nash

More
DG-DIAL-273-1
finished reviewing

1:26 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

Services

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Michael Garthwaite

Michael Garthwaite

wbracken (deleted user) and Sean Nash

Dara Navaei

Dara Navaei

Sean Nash

wbracken (deleted user) and Sean Nash

wbracken (deleted user)

Michael Garthwaite

Michael Garthwaite

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

wbracken (deleted user)

wbracken (deleted user)

Dara Navaei

Michael Garthwaite

Dara Navaei

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

Dara Navaei

Michael Garthwaite

Michael Garthwaite

wbracken (deleted user) and Sean Nash

wbracken (deleted user)