Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DG-DENBUG-96_Treatment Log Inaccuracies
DG-DENBUG-96_Treatment Log Inaccuracies
DG-DEN-16487_Dialin Config Helper Commands Are Not Supported With The Latest HD And DG Builds
DG-DEN-16487_Dialin Config Helper Commands Are Not Supported With The Latest HD And DG Builds
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Done

Done

sizeof should be first in if

sizeof should be first in if

Should this have a set of parenthesis around the condition similar to line 437?

Should this have a set of parenthesis around the condition similar to line 437?

Resolved in code review.

Resolved in code review.

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

Fixed.

Fixed.

Did this alarm change to HD?

Did this alarm change to HD?

DG-DEN-16372_Srsdg 907 Not Met
DG-DEN-16372_Srsdg 907 Not Met
In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Done

Done