dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Feb 2024
1:04 pm

Dara Navaei

DEN-16674 addressed the code reivew comment

Options
    • -5
    • +0
    ./SystemCommMessages.c
  2. … 1 more file in changeset.
1:04 pm

Dara Navaei

Done

Done

1:01 pm

Sean Nash

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

12:54 pm

Dara Navaei

No I will check the Dialin check in the function like the rest of the commands from Dialin.

No I will check the Dialin check in the function like the rest of the commands from Dialin.

12:50 pm

Sean Nash

I don't see change. Did you push?

I don't see change. Did you push?

12:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:58 am

Dara Navaei

Done

Done

10:53 am

Dara Navaei

Done

Done

10:52 am

Dara Navaei

Done

Done

10:51 am

Dara Navaei

Done. Added a check in the function in the Mode Fill like the rest of the modes and drivers.

Done. Added a check in the function in the Mode Fill like the rest of the modes and drivers.

10:50 am

Dara Navaei

Done

Done

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

Do this (request fill mode) in the testSetModeFillForCal() function above (and only if Dialin is logged in).

Do this (request fill mode) in the testSetModeFillForCal() function above (and only if Dialin is logged in).

10:32 am

Sean Nash

Make sure Dialin is logged in before accepting command.

Make sure Dialin is logged in before accepting command.

10:32 am

Sean Nash

If this is a Dialin command, make sure Dialin is logged in before acting on it (throughout this module).

If this is a Dialin command, make sure Dialin is logged in before acting on it (throughout this module).

10:31 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:30 am

Sean Nash

If these are Dialin commands, add a condition around this switch that Dialin has logged in.

If these are Dialin commands, add a condition around this switch that Dialin has logged in.

10:29 am

Sean Nash

These are Dialin commands? If so, prefix each enum with CMD_ and clarify this in comment.

These are Dialin commands? If so, prefix each enum with CMD_ and clarify this in comment.

9:14 am

Dara Navaei

8:36 am

Dara Navaei

DEN-16674 updated the code for mode fill calibration check command

Options
    • -0
    • +4
    ./SystemComm.c
    • -0
    • +33
    ./SystemCommMessages.c
    • -0
    • +3
    ./SystemCommMessages.h
  4. … 2 more files in changeset.
8:33 am

Dara Navaei

CD1 is used to check the difference between CD1 and CD2. CD1 is not used to check the reading of acid.

CD1 is used to check the difference between CD1 and CD2. CD1 is not used to check the reading of acid.

8:27 am

Dara Navaei

Will address in DEN-16693.

Will address in DEN-16693.

Tuesday 27 Feb 2024
3:55 pm

Sean Nash

All of these for loops are not following our coding standards. Should have bracketed scope even if single line of code in loop.

All of these for loops are not following our coding standards. Should have bracketed scope even if single line of code in loop.

3:54 pm

Sean Nash

Does this mean we aren't checking the CD1 sensor at all?

Does this mean we aren't checking the CD1 sensor at all?

Thursday 22 Feb 2024
11:06 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Dara Navaei

Yes this is still used in the deliver state. I changed the names in the #defines

Yes this is still used in the deliver state. I changed the names in the #defines

10:44 am

Sean Nash

Is this 5% definition still used? I don't think these are technically percentages (i.e. we do not mean 0.2%, we mean 20%).

Is this 5% definition still used?
I don't think these are technically percentages (i.e. we do not mean 0.2%, we mean 20%).