Tasks

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-13834 removed all the traces of DialysateFlow driver

  1. … 7 more files in changeset.
Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 t...

Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 typed variable so it will be typed properly. A #define may or may not be typed depending on how it's used. If it's used in a mathematical expression, the compiler will make it max precision (double) if we don't explicitly add the 'F' suffix and that can cause some problems with the precision in the math.

Remove blank line.

Remove blank line.

DEN-13598: Updates to FPGA clock speed check.

  1. … 2 more files in changeset.
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Use 0.0F

Use 0.0F

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

DEN-13598 updated the code

DEN-13598 updated the code with the RAM alarms

  1. … 4 more files in changeset.
DEN-13598 Updated code for RAM error checking.

Line 1902 is the same check but reverses the order.

Line 1902 is the same check but reverses the order.

This code is un-commented.

This code is un-commented.

Done.

Done.

In in DEN-13834.

In in DEN-13834.

Done.

Done.

Added TODO to un-comment this line of code.

Added TODO to un-comment this line of code.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

Done.

Done.

Done.

Done.

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the sema...

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.

Should this function handle invalid hex characters?

Should this function handle invalid hex characters?

Set "status" to FALSE.

Set "status" to FALSE.

Should this be removed?

Should this be removed?

Should variables in if be reversed?

Should variables in if be reversed?