dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 13 Mar 2021
9:18 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Addressed code review

Options
    • -8
    • +8
    ./Modes/ModeFill.c
    • -2
    • +2
    ./Services/SystemComm.c
    • -0
    • +19
    ./Services/SystemCommMessages.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
9:07 pm

Sean Nash

conver should be convert. Flow is in L/min.

conver should be convert. Flow is in L/min.

9:07 pm

qnguyen  (deleted user)

The return of this function includes a call to isWaterQualityGood(), which checks for inlet temp and conductivity, reject ratio, and temperature. For the dialysate temperature, it will be done once...

The return of this function includes a call to isWaterQualityGood(), which checks for inlet temp and conductivity, reject ratio, and temperature.
For the dialysate temperature, it will be done once I work on dialysate generation again and remove TODO.

8:43 pm

Sean Nash

Ok, yes, I see that now. But I still don't see any check for dialysate temperature (after heating).

Ok, yes, I see that now. But I still don't see any check for dialysate temperature (after heating).

7:45 pm

Sean Nash

Don't we need to check other things here as well? Inlet temp and conductivity, reject ratio, and dialysate temperature.

Don't we need to check other things here as well? Inlet temp and conductivity, reject ratio, and dialysate temperature.

7:33 pm

Sean Nash

I think there are now 7 incoming CAN msg buffers (8 if counting the 1 serial port buffer).

I think there are now 7 incoming CAN msg buffers (8 if counting the 1 serial port buffer).

7:21 pm

Sean Nash

DEN-7091: more load cell test code.

Options
    • -0
    • +2
    ./Controllers/LoadCell.c
6:42 pm

Sean Nash

DEN-7091: Added test code to test alpha filter for load cell readings.

Options
    • -4
    • +26
    ./Controllers/LoadCell.c
    • -0
    • +19
    ./Services/SystemCommMessages.c
    • -0
    • +1
    ./Services/SystemCommMessages.h
10:11 am

Dara Navaei

DEN-5963 tested the code

Options
    • -1
    • +1
    ./Controllers/Heaters.c
    • -18
    • +37
    ./Modes/ModeHeatDisinfect.c
Friday 12 Mar 2021
11:14 am

Dara Navaei

11:13 am

qnguyen  (deleted user) and Sean Nash

10:31 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:59 am

Dara Navaei

DEN-5963 tested the code in the lab

Options
    • -1
    • +1
    ./Controllers/ROPump.h
    • -108
    • +162
    ./Modes/ModeHeatDisinfect.c
    • -0
    • +2
    ./Modes/ModeHeatDisinfect.h
    • -1
    • +1
    ./Services/Reservoirs.c
Thursday 11 Mar 2021
4:35 pm

Peman Montazemi <pmontazemi@diality.com>

Added check fluid leak detector state outside of DG_INIT_MODE

Options
    • -16
    • +21
    ./Controllers/FluidLeak.c
4:28 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added handler for alarm clear

Options
    • -0
    • +4
    ./Services/SystemComm.c
1:56 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added new CAN channel for UI to DG comm

Options
    • -1
    • +1
    ./Modes/ModeStandby.c
    • -4
    • +5
    ./Services/CommBuffers.h
    • -3
    • +4
    ./Services/SystemComm.c
  4. … 2 more files in changeset.
12:33 pm

pmontazemi  (deleted user)

Addressed for both DG and HD.

Addressed for both DG and HD.

12:26 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Addressed code review comments

Options
    • -0
    • +2
    ./Controllers/FluidLeak.h
10:40 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

pmontazemi  (deleted user)

Because the fluid leak detector is packaged as part of a 16-bit (LSB + MSB) representing the GPIOs of the FPGA. This is to save space. I use a bitmask to extract that one bit I need which is repres...

Because the fluid leak detector is packaged as part of a 16-bit (LSB + MSB) representing the GPIOs of the FPGA. This is to save space. I use a bitmask to extract that one bit I need which is representative of the fluid leak detector state (dry/1 vs. wet/0).

10:28 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Addressed code review comments

Options
    • -0
    • +4
    ./Controllers/FluidLeak.c
Wednesday 10 Mar 2021
11:48 pm

Dara Navaei

Why is this called fpgaGPIO? Why not leakDetector or something that is more representative of your driver?

Why is this called fpgaGPIO? Why not leakDetector or something that is more representative of your driver?

11:45 pm

Dara Navaei

We started adding the sensors's part number and model. Could you please add it here?

We started adding the sensors's part number and model. Could you please add it here?

2:07 pm

pmontazemi  (deleted user)

2:02 pm

pmontazemi  (deleted user)

Removed.

Removed.

2:02 pm

pmontazemi  (deleted user)

Added.

Added.

2:01 pm

Peman Montazemi <pmontazemi@diality.com>

Addressed code review comments

Options
    • -2
    • +0
    ./Controllers/FluidLeak.c
    • -14
    • +18
    ./Tasks/TaskPriority.c
Tuesday 09 Mar 2021
4:58 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Removed unnecessary accelerometer calibration parameter message

Options
    • -4
    • +0
    ./Services/SystemComm.c