dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Mar 2021
2:43 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added build switch to disable dialysate checks

Options
    • -0
    • +8
    ./Controllers/ConductivitySensors.c
    • -0
    • +1
    ./DGCommon.h
    • -0
    • +6
    ./Modes/ModeFill.c
Sunday 14 Mar 2021
8:09 pm

Sean Nash

Shouldn't there be a few of these disinfect times? R1, R2, etc...

Shouldn't there be a few of these disinfect times? R1, R2, etc...

7:51 pm

Sean Nash

Delete blank line.

Delete blank line.

7:51 pm

Sean Nash

Delete blank line.

Delete blank line.

7:50 pm

Sean Nash

If we don't need this check anymore, just delete it.

If we don't need this check anymore, just delete it.

7:49 pm

Sean Nash

If we're not doing all of this commented out monitoring, just delete it.

If we're not doing all of this commented out monitoring, just delete it.

7:45 pm

Sean Nash

Why commented out here? If you don't want this disabled, comment the build switch out in DGCommon.h.

Why commented out here? If you don't want this disabled, comment the build switch out in DGCommon.h.

7:43 pm

Sean Nash

Why banner deleted?

Why banner deleted?

7:43 pm

Sean Nash

Why is this banner deleted?

Why is this banner deleted?

7:42 pm

Sean Nash

Why commented out?

Why commented out?

7:41 pm

Sean Nash

Why remove this check?

Why remove this check?

7:41 pm

Sean Nash

What is the purpose of this? If there is a problem, shouldn't there be an alarm/fault? Seems like current mode may not be aware that the drain pump has been stopped here.

What is the purpose of this? If there is a problem, shouldn't there be an alarm/fault? Seems like current mode may not be aware that the drain pump has been stopped here.

7:38 pm

Sean Nash

Not sure what's happening here. Restore this as it was.

Not sure what's happening here. Restore this as it was.

7:37 pm

Sean Nash

Why is this check commented out? Even if our RPM conversion is not great, we still need to be able to distinguish between off and on. Set a threshold and keep this check.

Why is this check commented out? Even if our RPM conversion is not great, we still need to be able to distinguish between off and on. Set a threshold and keep this check.

7:35 pm

Sean Nash

Why is all of this commented out? Just build switch the checks that aren't working and leave everything else alone.

Why is all of this commented out? Just build switch the checks that aren't working and leave everything else alone.

7:34 pm

Sean Nash

If this check isn't working, make a build switch to exclude them. What is the plan for this check? Can we even do it? If not, remove.

If this check isn't working, make a build switch to exclude them. What is the plan for this check? Can we even do it? If not, remove.

Saturday 13 Mar 2021
9:25 pm

qnguyen  (deleted user)

Fixed.

Fixed.

9:25 pm

qnguyen  (deleted user)

Fixed.

Fixed.

9:18 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Addressed code review

Options
    • -8
    • +8
    ./Modes/ModeFill.c
    • -2
    • +2
    ./Services/SystemComm.c
    • -0
    • +19
    ./Services/SystemCommMessages.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
9:07 pm

Sean Nash

conver should be convert. Flow is in L/min.

conver should be convert. Flow is in L/min.

9:07 pm

qnguyen  (deleted user)

The return of this function includes a call to isWaterQualityGood(), which checks for inlet temp and conductivity, reject ratio, and temperature. For the dialysate temperature, it will be done once...

The return of this function includes a call to isWaterQualityGood(), which checks for inlet temp and conductivity, reject ratio, and temperature.
For the dialysate temperature, it will be done once I work on dialysate generation again and remove TODO.

8:43 pm

Sean Nash

Ok, yes, I see that now. But I still don't see any check for dialysate temperature (after heating).

Ok, yes, I see that now. But I still don't see any check for dialysate temperature (after heating).

7:45 pm

Sean Nash

Don't we need to check other things here as well? Inlet temp and conductivity, reject ratio, and dialysate temperature.

Don't we need to check other things here as well? Inlet temp and conductivity, reject ratio, and dialysate temperature.

7:33 pm

Sean Nash

I think there are now 7 incoming CAN msg buffers (8 if counting the 1 serial port buffer).

I think there are now 7 incoming CAN msg buffers (8 if counting the 1 serial port buffer).

7:21 pm

Sean Nash

DEN-7091: more load cell test code.

Options
    • -0
    • +2
    ./Controllers/LoadCell.c
6:42 pm

Sean Nash

DEN-7091: Added test code to test alpha filter for load cell readings.

Options
    • -4
    • +26
    ./Controllers/LoadCell.c
    • -0
    • +19
    ./Services/SystemCommMessages.c
    • -0
    • +1
    ./Services/SystemCommMessages.h
10:11 am

Dara Navaei

DEN-5963 tested the code

Options
    • -1
    • +1
    ./Controllers/Heaters.c
    • -18
    • +37
    ./Modes/ModeHeatDisinfect.c
Friday 12 Mar 2021
11:14 am

Dara Navaei

11:13 am

qnguyen  (deleted user) and Sean Nash

10:31 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.