dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Mar 2021
4:28 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Changed operation mode broadcast rate to 4 Hz and added time out for water quality check

Options
    • -1
    • +12
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Modes/OperationModes.c
4:16 pm

Sean Nash

I prefer boolean conditions be explicit (e.g. TRUE == isThisLastDrain). This way, if value gets corrupted to a garbage value (like 5) it will be same as FALSE.

I prefer boolean conditions be explicit (e.g. TRUE == isThisLastDrain). This way, if value gets corrupted to a garbage value (like 5) it will be same as FALSE.

4:12 pm

Sean Nash

Should actuators be reset here too?

Should actuators be reset here too?

4:10 pm

Sean Nash

This doesn't look like a complete list of possible status. What are these used for?

This doesn't look like a complete list of possible status. What are these used for?

4:08 pm

Sean Nash

I thought hot and cold paths got merged into one?

I thought hot and cold paths got merged into one?

4:07 pm

Sean Nash

When is status unknown? And shouldn't there be a partially full status?

When is status unknown? And shouldn't there be a partially full status?

4:03 pm

Sean Nash

Align #define values on left.

Align #define values on left.

3:49 pm

Sean Nash

This looks tight. Will we pass? Do we need a bigger filter for temp sensors?

This looks tight. Will we pass? Do we need a bigger filter for temp sensors?

11:41 am

qnguyen  (deleted user)

Changed rate to 4 Hz.

Changed rate to 4 Hz.

11:40 am

qnguyen  (deleted user)

Added timeout.

Added timeout.

10:56 am

Sean Nash

Should we send DG modes more often? UI and HD stacks are keying off of these a lot and I worry 1 Hz will not be very responsive. I also worry there may be some modes/states that do not last 1 secon...

Should we send DG modes more often? UI and HD stacks are keying off of these a lot and I worry 1 Hz will not be very responsive. I also worry there may be some modes/states that do not last 1 second and HD may miss it.
If we speed this up, we should also speed up the HD modes broadcast as well.

10:51 am

Sean Nash

Do we need to know if concentrates door is closed before turning on pumps?

Do we need to know if concentrates door is closed before turning on pumps?

10:48 am

Sean Nash

Should we have a timeout on this?

Should we have a timeout on this?

10:08 am

Dara Navaei

Sunday 21 Mar 2021
5:18 pm

Dara Navaei

As a common practice, I use #pragma around the structs. Does that matter?

As a common practice, I use #pragma around the structs. Does that matter?

5:10 pm

Dara Navaei

I will use the older message IDs for other programs.

I will use the older message IDs for other programs.

5:10 pm

Dara Navaei

Because I used a different debugger and it updated the launch file. I think we should add this .gitignore.

Because I used a different debugger and it updated the launch file. I think we should add this .gitignore.

5:08 pm

Dara Navaei

Uncommented the code.

Uncommented the code.

5:07 pm

Dara Navaei

In this test, I was NVDatMgmt to be tested but not anything else.

In this test, I was NVDatMgmt to be tested but not anything else.

5:03 pm

Dara Navaei

That is true. I changed its place to right after RTC.

That is true. I changed its place to right after RTC.

4:40 pm

Dara Navaei

Dependencies are fine. It enables Bank7.

Dependencies are fine. It enables Bank7.

4:38 pm

Dara Navaei

To be able to run it on a board with not hardware. I used one of the older build switched instead.

To be able to run it on a board with not hardware. I used one of the older build switched instead.

4:36 pm

Dara Navaei

To be able to run them on a simple board on my desk. I made a build switch for this. I used one of the older build switches instead of commenting out.

To be able to run them on a simple board on my desk. I made a build switch for this. I used one of the older build switches instead of commenting out.

4:23 pm

Dara Navaei

It was commented out for testing. I un-commented it.

It was commented out for testing. I un-commented it.

3:43 pm

Dara Navaei

DEN-5963 pulled the latest changes from Sprint37

Options
    • -2
    • +2
    ./Controllers/ConductivitySensors.c
    • -0
    • +3
    ./Controllers/DrainPump.c
    • -9
    • +6
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
    • -2
    • +2
    ./Modes/ModeFill.c
    • -147
    • +63
    ./Modes/ModeHeatDisinfect.c
Friday 19 Mar 2021
11:10 pm

Dara Navaei

10:48 pm

Dara Navaei

DEN-5963 tested heat disinfect mode

Options
    • -66
    • +184
    ./Modes/ModeHeatDisinfect.c
    • -7
    • +0
    ./Services/Reservoirs.c
4:15 pm

Sean Nash

Fixed merge conflicts.

Options
    • -1
    • +1
    ./Modes/ModeDrain.c
    • -1
    • +1
    ./Modes/ModeRecirculate.c
    • -4
    • +12
    ./Modes/ModeStandby.c
    • -4
    • +4
    ./Modes/OperationModes.c
    • -0
    • +5
    ./Services/AlarmMgmt.h
    • -5
    • +1
    ./Services/Reservoirs.c
10:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

Sean Nash

Quang to address temperature in future branch. RESOLVED in CODE WALKTHROUGH.

Quang to address temperature in future branch. RESOLVED in CODE WALKTHROUGH.