dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Mar 2021
9:29 pm

Dara Navaei

DEN-5980 addressed code review comments

Options
    • -32
    • +32
    ./Controllers/Heaters.c
    • -2
    • +2
    ./Controllers/ROPump.c
    • -1
    • +1
    ./DGCommon.h
    • -7
    • +6
    ./Modes/ModeInitPOST.c
    • -6
    • +8
    ./Tasks/TaskGeneral.c
    • -8
    • +10
    ./Tasks/TaskPriority.c
  7. … 1 more file in changeset.
5:17 pm

Sean Nash

Can we log 2 data with alarms (set alarm and a data value when detected, log with alarm here)?

Can we log 2 data with alarms (set alarm and a data value when detected, log with alarm here)?

5:12 pm

Sean Nash

Is this the new "coldest spot" sensor?

Is this the new "coldest spot" sensor?

5:11 pm

Sean Nash

Can drain time out in this state? Why no check?

Can drain time out in this state? Why no check?

5:08 pm

Sean Nash

What is this state doing?

What is this state doing?

5:08 pm

Sean Nash

Are these the only two faults that can happen in R1 to R2 state?

Are these the only two faults that can happen in R1 to R2 state?

4:57 pm

Sean Nash

I prefer to reverse the order of these to change accidental = instead of ==.

I prefer to reverse the order of these to change accidental = instead of ==.

4:53 pm

Sean Nash

Check boolean explicitly.

Check boolean explicitly.

4:49 pm

Sean Nash

Check these booleans explicitly.

Check these booleans explicitly.

4:48 pm

Sean Nash

Set these booleans to TRUE or FALSE explicitly.

Set these booleans to TRUE or FALSE explicitly.

4:47 pm

Sean Nash

Is Thd same as TRo? Does it belong in this group?

Is Thd same as TRo? Does it belong in this group?

4:42 pm

Sean Nash

This comment needs a rephrase. I don't think range has anything to do with it. This is a retry counter check.

This comment needs a rephrase. I don't think range has anything to do with it. This is a retry counter check.

4:38 pm

Sean Nash

Recommend being much more descriptive of these states. What exactly is the state trying to accomplish.

Recommend being much more descriptive of these states. What exactly is the state trying to accomplish.

4:33 pm

Sean Nash

Why no actuators set for draining R2 here? I see VRd being set a few lines down. Maybe move this comment to go with the valve change.

Why no actuators set for draining R2 here? I see VRd being set a few lines down. Maybe move this comment to go with the valve change.

4:29 pm

qnguyen  (deleted user)

Checked with Nick. The DG does not expose motors to the user. The straw door switch should be open in Fill Mode to allow access to straw connection. The straw door switch should be closed in modes ...

Checked with Nick. The DG does not expose motors to the user.
The straw door switch should be open in Fill Mode to allow access to straw connection.
The straw door switch should be closed in modes such as (heat disinfection, chem disinfection) to prevent user from exposure to hot water or chemical.

Added TODO.

4:28 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Changed operation mode broadcast rate to 4 Hz and added time out for water quality check

Options
    • -1
    • +12
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Modes/OperationModes.c
4:16 pm

Sean Nash

I prefer boolean conditions be explicit (e.g. TRUE == isThisLastDrain). This way, if value gets corrupted to a garbage value (like 5) it will be same as FALSE.

I prefer boolean conditions be explicit (e.g. TRUE == isThisLastDrain). This way, if value gets corrupted to a garbage value (like 5) it will be same as FALSE.

4:12 pm

Sean Nash

Should actuators be reset here too?

Should actuators be reset here too?

4:10 pm

Sean Nash

This doesn't look like a complete list of possible status. What are these used for?

This doesn't look like a complete list of possible status. What are these used for?

4:08 pm

Sean Nash

I thought hot and cold paths got merged into one?

I thought hot and cold paths got merged into one?

4:07 pm

Sean Nash

When is status unknown? And shouldn't there be a partially full status?

When is status unknown? And shouldn't there be a partially full status?

4:03 pm

Sean Nash

Align #define values on left.

Align #define values on left.

3:49 pm

Sean Nash

This looks tight. Will we pass? Do we need a bigger filter for temp sensors?

This looks tight. Will we pass? Do we need a bigger filter for temp sensors?

11:41 am

qnguyen  (deleted user)

Changed rate to 4 Hz.

Changed rate to 4 Hz.

11:40 am

qnguyen  (deleted user)

Added timeout.

Added timeout.

10:56 am

Sean Nash

Should we send DG modes more often? UI and HD stacks are keying off of these a lot and I worry 1 Hz will not be very responsive. I also worry there may be some modes/states that do not last 1 secon...

Should we send DG modes more often? UI and HD stacks are keying off of these a lot and I worry 1 Hz will not be very responsive. I also worry there may be some modes/states that do not last 1 second and HD may miss it.
If we speed this up, we should also speed up the HD modes broadcast as well.

10:51 am

Sean Nash

Do we need to know if concentrates door is closed before turning on pumps?

Do we need to know if concentrates door is closed before turning on pumps?

10:48 am

Sean Nash

Should we have a timeout on this?

Should we have a timeout on this?

10:08 am

Dara Navaei

Sunday 21 Mar 2021
5:18 pm

Dara Navaei

As a common practice, I use #pragma around the structs. Does that matter?

As a common practice, I use #pragma around the structs. Does that matter?