dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 24 Mar 2021
12:38 pm

Dara Navaei

DEN-5980 addressed code review comments

Options
    • -0
    • +1
    ./Controllers/DrainPump.c
    • -1
    • +2
    ./Tasks/TaskGeneral.c
    • -2
    • +2
    ./Tasks/TaskPriority.c
  4. … 1 more file in changeset.
12:37 pm

Dara Navaei

This section is monitoring the RPM of the drain pump and makes decision accordingly. This must be commented out until we figure out how to convert counts into RPM properly. I added a TODO note for ...

This section is monitoring the RPM of the drain pump and makes decision accordingly. This must be commented out until we figure out how to convert counts into RPM properly. I added a TODO note for that.

12:26 pm

Dara Navaei

Done.

Done.

12:25 pm

Dara Navaei

Yes. This state machine is only used when a record data is scheduled to be sent to Dialin in batches.

Yes. This state machine is only used when a record data is scheduled to be sent to Dialin in batches.

12:23 pm

Dara Navaei

Changed them to NVDataMgmt NVDataMgmt.

Changed them to NVDataMgmt NVDataMgmt.

12:23 pm

Dara Navaei

These string fields are not null terminated. We will used them as characters and they are not used anywhere in the firmware.

These string fields are not null terminated. We will used them as characters and they are not used anywhere in the firmware.

12:21 pm

Dara Navaei

I wanted to use enum specifically for calibration purposes. Their names also contain the word CAL.

I wanted to use enum specifically for calibration purposes. Their names also contain the word CAL.

12:20 pm

Dara Navaei

Done.

Done.

12:19 pm

Dara Navaei

Done.

Done.

12:18 pm

Dara Navaei

Done.

Done.

12:18 pm

Dara Navaei

I updated the comment.

I updated the comment.

12:15 pm

Dara Navaei

Done.

Done.

12:14 pm

Dara Navaei

Done.

Done.

12:11 pm

Dara Navaei

To make sure dequeuing is not interrupted.

To make sure dequeuing is not interrupted.

Tuesday 23 Mar 2021
11:18 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:17 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:17 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:08 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:08 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:06 am

qnguyen  (deleted user)

Why do we need to disable interrupt? Is it a critical function?

Why do we need to disable interrupt? Is it a critical function?

11:06 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:05 am

qnguyen  (deleted user)

Update function description.

Update function description.

11:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:00 am

qnguyen  (deleted user)

Add () between each condition.

Add () between each condition.

10:59 am

Sean Nash

Not just for calibration record.

Not just for calibration record.

10:59 am

qnguyen  (deleted user)

Add "TRUE == " to the comparison.

Add "TRUE == " to the comparison.

10:55 am

qnguyen  (deleted user)

Uncomment code.

Uncomment code.