dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 09 Apr 2021
12:46 pm

Dara Navaei

DEN-7568 worked on mode flush

Options
    • -2
    • +3
    ./Controllers/DrainPump.c
    • -2
    • +2
    ./Controllers/TemperatureSensors.c
    • -4
    • +526
    ./Modes/ModeFlush.c
    • -0
    • +10
    ./Modes/ModeFlush.h
    • -0
    • +22
    ./Modes/ModeStandby.c
    • -0
    • +2
    ./Modes/ModeStandby.h
    • -0
    • +1
    ./Services/AlarmMgmt.h
    • -350
    • +372
    ./Services/Reservoirs.c
    • -39
    • +43
    ./Services/Reservoirs.h
    • -0
    • +4
    ./Services/SystemComm.c
    • -1
    • +71
    ./Services/SystemCommMessages.c
    • -0
    • +7
    ./Services/SystemCommMessages.h
  13. … 1 more file in changeset.
Thursday 08 Apr 2021
1:11 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Updated concentrate pump driver

Options
    • -5
    • +9
    ./Controllers/ConcentratePumps.c
    • -1
    • +2
    ./Controllers/TemperatureSensors.c
12:18 pm

pmontazemi  (deleted user)

Comments shall start with capital letter.

Comments shall start with capital letter.

12:12 pm

pmontazemi  (deleted user)

Replace a with a more meaningful variable name.

Replace a with a more meaningful variable name.

12:06 pm

pmontazemi  (deleted user)

Align comment.

Align comment.

11:28 am

pmontazemi  (deleted user)

Align comment.

Align comment.

11:27 am

pmontazemi  (deleted user)

Add TODO or delete.

Add TODO or delete.

11:27 am

pmontazemi  (deleted user)

Replace logic with a temp parameter (call it whatever you like) and then use that parameter in the function call. This will make the code a lot more legible.

Replace logic with a temp parameter (call it whatever you like) and then use that parameter in the function call. This will make the code a lot more legible.

11:25 am

pmontazemi  (deleted user)

Why not using a union? Much more optimized for memory-limited devices.

Why not using a union? Much more optimized for memory-limited devices.

11:17 am

pmontazemi  (deleted user)

Where did these go?

Where did these go?

11:17 am

pmontazemi  (deleted user)

Remove "for" at end of @param sentence.

Remove "for" at end of @param sentence.

11:17 am

pmontazemi  (deleted user)

Remove "for" at end of @param sentence.

Remove "for" at end of @param sentence.

11:15 am

pmontazemi  (deleted user)

Why using structs instead of enums?

Why using structs instead of enums?

11:14 am

pmontazemi  (deleted user)

...operating temperatures between 5 degrees C and 95 degrees C.

...operating temperatures between 5 degrees C and 95 degrees C.

11:14 am

pmontazemi  (deleted user)

...operating temperatures between 5 degrees C and 95 degrees C.

...operating temperatures between 5 degrees C and 95 degrees C.

10:54 am

pmontazemi  (deleted user)

Why commented out?

Why commented out?

10:54 am

pmontazemi  (deleted user)

If both of these functions are using the same constant, why do we have two functions? Use just one (unless it is planned for them to inherit different constants down the road).

If both of these functions are using the same constant, why do we have two functions? Use just one (unless it is planned for them to inherit different constants down the road).

10:52 am

pmontazemi  (deleted user)

Why commented out?

Why commented out?

10:50 am

pmontazemi  (deleted user)

Spell out P in variable name (or use "Press" at least).

Spell out P in variable name (or use "Press" at least).

10:48 am

pmontazemi  (deleted user)

Did we want to mention "set" in the two variables' name?

Did we want to mention "set" in the two variables' name?

12:16 am

qnguyen  (deleted user)

Do we need to check for maximum limit here? What is the use of conductivity in this case?

Do we need to check for maximum limit here? What is the use of conductivity in this case?

Wednesday 07 Apr 2021
10:58 pm

qnguyen  (deleted user)

load cell enum needs to be fixed.

load cell enum needs to be fixed.

10:38 pm

qnguyen  (deleted user)

Align the defines. Doxygen comment can be moved up one line using ///.

Align the defines. Doxygen comment can be moved up one line using ///.

10:33 pm

qnguyen  (deleted user)

This should be an or.

This should be an or.

11:06 am

Dara Navaei

11:05 am

Dara Navaei

11:01 am

Dara Navaei

Merge branch 'DEN-5980-non-volatile-data-management-2-of-2' into staging

Options
    • -2
    • +2
    ./DGCommon.h
10:47 am

pmontazemi  (deleted user) , Sean Nash and qnguyen  (deleted user)

9:10 am

Dara Navaei

DEN-5980 disabled a build switch

Options
    • -2
    • +2
    ./DGCommon.h
    • -1
    • +1
    ./Tasks/TaskGeneral.c
Tuesday 06 Apr 2021
9:12 pm

Dara Navaei

DG-DEN-5980_Non Volatile Data Management (2 of 2)
DG-DEN-5980_Non Volatile Data Management (2 of 2)