dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 13 Apr 2021
3:53 pm

Dara Navaei

DEN-7568 worked on mode flush

Options
    • -64
    • +59
    ./Modes/ModeFlush.c
    • -1
    • +1
    ./Modes/ModeStandby.c
1:34 pm

qnguyen  (deleted user)

Dara Navaei Please refactor the name to cp1CurrentSetSpeed and cp2CurrentSetSpeed. Thank you!

Dara Navaei Please refactor the name to cp1CurrentSetSpeed and cp2CurrentSetSpeed. Thank you!

1:27 pm

qnguyen  (deleted user)

Union is not applicable in this case. Every field of this struct has a different value to be stored.

Union is not applicable in this case. Every field of this struct has a different value to be stored.

1:25 pm

qnguyen  (deleted user)

Both false and true cases are needed (for clear and trigger alarm). Recommend turning the if statement into a variable and pass in as parameter.

Both false and true cases are needed (for clear and trigger alarm). Recommend turning the if statement into a variable and pass in as parameter.

12:46 pm

Dara Navaei

DEN-5963 addressed code review comments

Options
    • -6
    • +10
    ./Controllers/DrainPump.c
    • -1
    • +1
    ./Controllers/DrainPump.h
    • -1
    • +1
    ./Controllers/Fans.c
    • -2
    • +4
    ./Controllers/Heaters.c
    • -0
    • +2
    ./Controllers/Heaters.h
    • -1
    • +1
    ./Controllers/LoadCell.c
    • -13
    • +0
    ./Controllers/Pressures.c
    • -1
    • +5
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Modes/ModeDrain.c
    • -30
    • +33
    ./Modes/ModeHeatDisinfect.c
    • -1
    • +1
    ./Modes/ModeStandby.c
    • -3
    • +11
    ./Services/SystemCommMessages.c
10:19 am

Dara Navaei

Nice catch. Done.

Nice catch. Done.

10:18 am

Dara Navaei

Done.

Done.

10:16 am

Dara Navaei

This section was for debugging only. I removed it.

This section was for debugging only. I removed it.

9:50 am

Dara Navaei

[~qnguyen] Could you please address?

[~qnguyen] Could you please address?

9:49 am

Dara Navaei

I spelled it completely.

I spelled it completely.

9:48 am

Dara Navaei

The small and main primary duty cycles are on different PWM channels. They cannot be controlled with one function.

The small and main primary duty cycles are on different PWM channels. They cannot be controlled with one function.

9:45 am

Dara Navaei

This struct is the structure that is used to set the dialysate target temperature using the CAN bus. I do not think we can use enums for this purpose.

This struct is the structure that is used to set the dialysate target temperature using the CAN bus. I do not think we can use enums for this purpose.

9:39 am

Dara Navaei

Done.

Done.

9:38 am

Dara Navaei

Done.

Done.

9:33 am

Dara Navaei

Done.

Done.

9:32 am

Dara Navaei

Done.

Done.

9:31 am

Dara Navaei

Done.

Done.

Monday 12 Apr 2021
11:04 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Sean Nash

Moved to common DGDefs.h (in staging branch).

Moved to common DGDefs.h (in staging branch).

Sunday 11 Apr 2021
9:20 am

Dara Navaei

DEN-7568 added timeout conditional statements for mode flush

Options
    • -15
    • +95
    ./Modes/ModeFlush.c
    • -0
    • +2
    ./Services/SystemCommMessages.c
Saturday 10 Apr 2021
4:12 pm

Dara Navaei

DEN-7568 developed and tested the flush mode

Options
    • -196
    • +138
    ./Controllers/ROPump.c
    • -6
    • +6
    ./Controllers/ROPump.h
    • -31
    • +211
    ./Modes/ModeFlush.c
    • -1
    • +2
    ./Modes/ModeStandby.c
    • -6
    • +6
    ./Services/PIControllers.c
    • -2
    • +2
    ./Services/PIControllers.h
    • -1
    • +6
    ./Services/Reservoirs.c
  8. … 1 more file in changeset.
Friday 09 Apr 2021
12:46 pm

Dara Navaei

DEN-7568 worked on mode flush

Options
    • -2
    • +3
    ./Controllers/DrainPump.c
    • -2
    • +2
    ./Controllers/TemperatureSensors.c
    • -4
    • +526
    ./Modes/ModeFlush.c
    • -0
    • +10
    ./Modes/ModeFlush.h
    • -0
    • +22
    ./Modes/ModeStandby.c
    • -0
    • +2
    ./Modes/ModeStandby.h
    • -0
    • +1
    ./Services/AlarmMgmt.h
    • -350
    • +372
    ./Services/Reservoirs.c
    • -39
    • +43
    ./Services/Reservoirs.h
    • -0
    • +4
    ./Services/SystemComm.c
    • -1
    • +71
    ./Services/SystemCommMessages.c
    • -0
    • +7
    ./Services/SystemCommMessages.h
  13. … 1 more file in changeset.
Thursday 08 Apr 2021
1:11 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Updated concentrate pump driver

Options
    • -5
    • +9
    ./Controllers/ConcentratePumps.c
    • -1
    • +2
    ./Controllers/TemperatureSensors.c
12:18 pm

pmontazemi  (deleted user)

Comments shall start with capital letter.

Comments shall start with capital letter.

12:12 pm

pmontazemi  (deleted user)

Replace a with a more meaningful variable name.

Replace a with a more meaningful variable name.