dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 14 Apr 2021
10:25 am

Dara Navaei

DEN-5963 addressed code review comments

Options
    • -1
    • +1
    ./Controllers/Heaters.c
    • -10
    • +9
    ./Controllers/ROPump.c
    • -5
    • +3
    ./Controllers/TemperatureSensors.c
    • -102
    • +104
    ./Modes/ModeHeatDisinfect.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.h
    • -5
    • +6
    ./Modes/ModeStandby.c
    • -9
    • +6
    ./Services/SystemCommMessages.c
10:24 am

Dara Navaei

Done.

Done.

10:14 am

Dara Navaei

This is just to check that everything above minimum we are about to start the heat disifnect mode. I added the max limit too.

This is just to check that everything above minimum we are about to start the heat disifnect mode. I added the max limit too.

10:13 am

Dara Navaei

I removed 2. If faster publish time is needed, it should be overridden via Dialin.

I removed 2. If faster publish time is needed, it should be overridden via Dialin.

10:12 am

Dara Navaei

Done.

Done.

10:11 am

Dara Navaei

Done.

Done.

10:10 am

Dara Navaei

This section has been uncommented.

This section has been uncommented.

9:21 am

Dara Navaei

Done.

Done.

9:19 am

Dara Navaei

I changed the functions.

I changed the functions.

9:19 am

Dara Navaei

Done.

Done.

9:19 am

Dara Navaei

This enum has been deleted.

This enum has been deleted.

9:18 am

Dara Navaei

This enum has been deleted.

This enum has been deleted.

9:18 am

Dara Navaei

That is tested in the start state.

That is tested in the start state.

9:17 am

Dara Navaei

Done.

Done.

9:01 am

Dara Navaei

I renamed the function. This part has been changed and the current state will not be overridden.

I renamed the function. This part has been changed and the current state will not be overridden.

8:58 am

Dara Navaei

The global check has been removed. PPi is checked here.

The global check has been removed. PPi is checked here.

8:58 am

Dara Navaei

It depends on where it is going. If it is the last drain, it turns off the drain pump.

It depends on where it is going. If it is the last drain, it turns off the drain pump.

8:57 am

Dara Navaei

This enum has been deleted.

This enum has been deleted.

8:56 am

Dara Navaei

This variable has been deleted.

This variable has been deleted.

8:55 am

Dara Navaei

This variable has been deleted.

This variable has been deleted.

8:53 am

Dara Navaei

Yes, the purpose is to check whether the level changes, either going up or down.

Yes, the purpose is to check whether the level changes, either going up or down.

8:52 am

Dara Navaei

Done.

Done.

Tuesday 13 Apr 2021
3:54 pm

Dara Navaei

DG-DEN-7568_DG Mode Flush
DG-DEN-7568_DG Mode Flush
3:53 pm

Dara Navaei

DEN-7568 worked on mode flush

Options
    • -64
    • +59
    ./Modes/ModeFlush.c
    • -1
    • +1
    ./Modes/ModeStandby.c
1:34 pm

qnguyen  (deleted user)

Dara Navaei Please refactor the name to cp1CurrentSetSpeed and cp2CurrentSetSpeed. Thank you!

Dara Navaei Please refactor the name to cp1CurrentSetSpeed and cp2CurrentSetSpeed. Thank you!

1:27 pm

qnguyen  (deleted user)

Union is not applicable in this case. Every field of this struct has a different value to be stored.

Union is not applicable in this case. Every field of this struct has a different value to be stored.

1:25 pm

qnguyen  (deleted user)

Both false and true cases are needed (for clear and trigger alarm). Recommend turning the if statement into a variable and pass in as parameter.

Both false and true cases are needed (for clear and trigger alarm). Recommend turning the if statement into a variable and pass in as parameter.

12:46 pm

Dara Navaei

DEN-5963 addressed code review comments

Options
    • -6
    • +10
    ./Controllers/DrainPump.c
    • -1
    • +1
    ./Controllers/DrainPump.h
    • -1
    • +1
    ./Controllers/Fans.c
    • -2
    • +4
    ./Controllers/Heaters.c
    • -0
    • +2
    ./Controllers/Heaters.h
    • -1
    • +1
    ./Controllers/LoadCell.c
    • -13
    • +0
    ./Controllers/Pressures.c
    • -1
    • +5
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Modes/ModeDrain.c
    • -30
    • +33
    ./Modes/ModeHeatDisinfect.c
    • -1
    • +1
    ./Modes/ModeStandby.c
    • -3
    • +11
    ./Services/SystemCommMessages.c
10:19 am

Dara Navaei

Nice catch. Done.

Nice catch. Done.

10:18 am

Dara Navaei

Done.

Done.