dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 19 Apr 2021
2:00 pm

Dara Navaei

DEN-5963 remerged staging

Options
    • -14
    • +14
    ./Controllers/ConcentratePumps.c
    • -2
    • +2
    ./Controllers/ConcentratePumps.h
    • -2
    • +13
    ./Controllers/DrainPump.c
    • -15
    • +14
    ./Controllers/Heaters.c
    • -57
    • +152
    ./Controllers/LoadCell.c
    • -1
    • +2
    ./Controllers/LoadCell.h
    • -1
    • +3
    ./Controllers/Pressures.c
    • -1
    • +3
    ./Controllers/TemperatureSensors.c
    • -3
    • +9
    ./DGCommon.h
    • -1
    • +1
    ./Modes/ModeDrain.c
    • -3
    • +7
    ./Modes/ModeRecirculate.c
    • -32
    • +168
    ./Modes/ModeStandby.c
    • -1
    • +1
    ./Modes/ModeStandby.h
    • -5
    • +5
    ./Modes/OperationModes.c
    • -1
    • +2
    ./Services/AlarmMgmt.c
  16. … 8 more files in changeset.
11:57 am

qnguyen  (deleted user)

Should we remove = so we only error when greater than?

Should we remove = so we only error when greater than?

11:46 am

Dara Navaei

Done.

Done.

11:01 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:01 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:00 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:00 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:59 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:59 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:58 am

Dara Navaei

Done.

Done.

10:58 am

Dara Navaei

I uncommented it.

I uncommented it.

10:57 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

Dara Navaei

DEN-5963 addressed a code review comment

Options
    • -0
    • +2
    ./Controllers/ROPump.c
    • -3
    • +3
    ./Modes/ModeHeatDisinfect.c
    • -7
    • +7
    ./Services/AlarmMgmt.c
10:54 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:50 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:48 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:20 am

qnguyen  (deleted user)

Should we refactor the name then? It looks like A1 goes with B1, and A2 goes with B2 with the current name.

Should we refactor the name then? It looks like A1 goes with B1, and A2 goes with B2 with the current name.

9:23 am

Dara Navaei

Done.

Done.

9:17 am

Sean Nash

Inputs are data looked at in this function (e.g. in an if statement). Outputs are data that are changed in this function.

Inputs are data looked at in this function (e.g. in an if statement). Outputs are data that are changed in this function.