dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 13 Jun 2021
5:35 pm

Dara Navaei

DEN-8030 addressed code review comments

Options
    • -4
    • +17
    ./Modes/ModeChemicalDisinfect.c
5:27 pm

Dara Navaei

DEN-8030 addressed code review comments

Options
    • -2
    • +7
    ./Controllers/Heaters.c
    • -0
    • +1
    ./Controllers/TemperatureSensors.h
    • -1
    • +1
    ./DGCommon.h
    • -6
    • +4
    ./Modes/ModeChemicalDisinfect.c
    • -4
    • +24
    ./Modes/ModeHeatDisinfect.c
    • -2
    • +2
    ./Modes/ModeRecirculate.c
    • -28
    • +1
    ./Modes/ModeStandby.c
    • -0
    • +2
    ./Services/Reservoirs.c
    • -0
    • +1
    ./Services/SystemComm.c
    • -1
    • +0
    ./Services/SystemCommMessages.c
5:22 pm

Dara Navaei

Done

Done

4:19 pm

Dara Navaei

Done.

Done.

4:19 pm

Dara Navaei

Done.

Done.

4:19 pm

Dara Navaei

This was for testing. It is uncommented.

This was for testing. It is uncommented.

4:18 pm

Dara Navaei

Done.

Done.

4:17 pm

Dara Navaei

I removed it.

I removed it.

4:10 pm

Dara Navaei

Done

Done

4:08 pm

Dara Navaei

I removed the function.

I removed the function.

4:01 pm

Dara Navaei

Done.

Done.

4:00 pm

Dara Navaei

Done.

Done.

3:59 pm

Dara Navaei

DEN-8030 merged staging

Options
    • -4
    • +109
    ./Controllers/DrainPump.c
    • -0
    • +1
    ./Controllers/LoadCell.c
    • -10
    • +5
    ./Controllers/TemperatureSensors.c
    • -15
    • +76
    ./Controllers/Valves.c
    • -0
    • +1
    ./Controllers/Valves.h
    • -3
    • +4
    ./DGCommon.h
    • -19
    • +69
    ./Modes/ModeDrain.c
    • -0
    • +7
    ./Modes/ModeFault.c
    • -2
    • +143
    ./Modes/ModeHeatDisinfect.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.h
    • -13
    • +44
    ./Modes/ModeInitPOST.c
    • -0
    • +2
    ./Modes/ModeRecirculate.c
    • -1
    • +1
    ./Modes/ModeStandby.c
    • -0
    • +14
    ./Modes/OperationModes.c
    • -2
    • +2
    ./Services/AlarmMgmt.h
  16. … 7 more files in changeset.
2:52 pm

Dara Navaei

DEN-8030 added a more code to the cooling stage of the RO filter in heat disinfect

Options
    • -183
    • +15
    ./Controllers/Heaters.c
    • -2
    • +0
    ./Controllers/Heaters.h
    • -2
    • +2
    ./Controllers/LoadCell.c
    • -0
    • +5
    ./Modes/ModeDrain.c
    • -1
    • +4
    ./Modes/ModeFill.c
    • -69
    • +130
    ./Modes/ModeHeatDisinfect.c
    • -2
    • +2
    ./Modes/ModeHeatDisinfect.h
    • -6
    • +0
    ./Modes/ModeInitPOST.c
    • -3
    • +7
    ./Modes/ModeRecirculate.c
    • -1
    • +1
    ./Services/Reservoirs.c
Thursday 10 Jun 2021
3:21 pm

Sean Nash

3:05 pm

qnguyen  (deleted user) , Dara Navaei and pmontazemi  (deleted user)

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

DEN-7605: Local merge w/ staging.

Options
    • -2
    • +4
    ./Controllers/ROPump.c
    • -18
    • +44
    ./Controllers/TemperatureSensors.c
    • -3
    • +3
    ./DGCommon.h
    • -1
    • +40
    ./Modes/ModeFault.c
    • -12
    • +891
    ./Modes/ModeFlush.c
    • -14
    • +43
    ./Modes/ModeHeatDisinfect.c
    • -0
    • +23
    ./Modes/ModeStandby.c
    • -1
    • +2
    ./Services/AlarmMgmt.h
    • -252
    • +254
    ./Services/Reservoirs.c
    • -16
    • +15
    ./Services/Reservoirs.h
    • -0
    • +4
    ./Services/SystemComm.c
    • -0
    • +63
    ./Services/SystemCommMessages.c
    • -0
    • +7
    ./Services/SystemCommMessages.h
  14. … 1 more file in changeset.
9:59 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Fixed conductivity fault condition

Options
    • -5
    • +13
    ./Controllers/ConductivitySensors.c
    • -7
    • +7
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Modes/ModeRecirculate.c
9:34 am

Sean Nash

I think we should not stop RO pump or heater. Just go to drain like production state (but no mixing).

I think we should not stop RO pump or heater. Just go to drain like production state (but no mixing).

9:31 am

Sean Nash

Call checkDialysateConductivity() once at top of function. Then use return value for the two if conditions. Also, this second if should be an else if to ensure you don't do both.

Call checkDialysateConductivity() once at top of function. Then use return value for the two if conditions.
Also, this second if should be an else if to ensure you don't do both.

Wednesday 09 Jun 2021
9:36 am

Sean Nash

DEN-7605: Re-ordered DG POST tests. Fixed comments.

Options
    • -1
    • +1
    ./Controllers/Voltages.c
    • -1
    • +1
    ./Controllers/Voltages.h
    • -6
    • +6
    ./Modes/ModeInitPOST.c
Tuesday 08 Jun 2021
11:46 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
11:46 pm

Sean Nash

V3 build.

Options
    • -2
    • +2
    ./DGCommon.h
4:26 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Fixed water sample

Options
    • -1
    • +10
    ./Modes/ModeStandby.c
1:55 pm

Dara Navaei

DEN-8030 updated the drain pump RPM conversion

Options
    • -4
    • +4
    ./Controllers/DrainPump.c
    • -3
    • +3
    ./Modes/ModeChemicalDisinfect.c
    • -4
    • +9
    ./Modes/ModeHeatDisinfect.c
Monday 07 Jun 2021
11:41 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Transition to fault mode if alarm is a DG fault alarm

Options
    • -2
    • +2
    ./Services/AlarmMgmt.c
3:42 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
1:57 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h