dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Jun 2021
11:08 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Added missing header and removed redundant function declaration

Options
    • -6
    • +3
    ./Services/SystemCommMessages.h
  2. … 1 more file in changeset.
10:47 am

Dara Navaei

DEN-8030 updated the documentation

Options
    • -2
    • +1
    ./Modes/ModeHeatDisinfect.c
10:38 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:13 am

Dara Navaei

DEN-8030 adderessed a code review comment

Options
    • -1
    • +0
    ./Controllers/Heaters.c
    • -22
    • +0
    ./Controllers/ROPump.c
    • -2
    • +0
    ./Controllers/ROPump.h
    • -1
    • +1
    ./DGCommon.h
10:12 am

Dara Navaei

This a matter of trying the temperature sensors more than once before we start the cycle. Making the wait time longer will not necessarily help the sensors to read within the range.

This a matter of trying the temperature sensors more than once before we start the cycle. Making the wait time longer will not necessarily help the sensors to read within the range.

Friday 18 Jun 2021
3:37 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
3:36 pm

Sean Nash

Merge branch 'develop' of ssh://dvm-linux02:7999/dg/dgfirmware into develop

Options
    • -1
    • +1
    ./DGCommon.h
3:36 pm

Sean Nash

HalCOGen fixes. Merge fixes.

Options
    • -1
    • +1
    ./DGCommon.h
    • -4
    • +4
    ./Modes/ModeChemicalDisinfect.c
  3. … 6 more files in changeset.
2:31 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
Thursday 17 Jun 2021
10:59 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:58 am

Dara Navaei

DEN-8030 addressed code review comments

Options
    • -3
    • +3
    ./Modes/ModeChemicalDisinfect.c
    • -12
    • +12
    ./Modes/ModeHeatDisinfect.c
  3. … 3 more files in changeset.
10:57 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:53 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:19 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
10:09 am

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-8103-dg-hd_dev-alarm-design' into develop

Options
    • -1
    • +1
    ./Controllers/ConductivitySensors.c
    • -1
    • +1
    ./Controllers/DrainPump.c
    • -49
    • +21
    ./Controllers/Heaters.c
    • -13
    • +13
    ./Controllers/LoadCell.c
    • -3
    • +3
    ./Controllers/UVReactors.c
    • -0
    • +1
    ./DGCommon.h
    • -1
    • +5
    ./Modes/ModeFault.c
    • -2
    • +2
    ./Modes/ModeFlush.c
    • -3
    • +3
    ./Modes/ModeHeatDisinfect.c
    • -2
    • +0
    ./Modes/ModeRecirculate.c
    • -2
    • +79
    ./Modes/ModeStandby.c
    • -2
    • +4
    ./Modes/ModeStandby.h
    • -0
    • +133
    ./Services/AlarmMgmtSWFaults.h
    • -2
    • +14
    ./Services/FPGA.c
    • -0
    • +2
    ./Services/FPGA.h
  16. … 4 more files in changeset.
9:56 am

Dara Navaei

DEN-8030 addressed code review comments

Options
    • -2
    • +2
    ./Controllers/LoadCell.c
    • -0
    • +1
    ./DGCommon.h
    • -17
    • +18
    ./Modes/ModeChemicalDisinfect.c
    • -21
    • +1
    ./Modes/ModeDrain.c
    • -5
    • +0
    ./Modes/ModeFill.c
    • -13
    • +27
    ./Modes/ModeHeatDisinfect.c
    • -12
    • +0
    ./Modes/ModeHeatDisinfect.h
  8. … 3 more files in changeset.
9:56 am

Dara Navaei

CONC_PUMPS_REVERSE_SPEED_ML_PER_MIN = -30.0 to indicate that the direction is in reverse.

CONC_PUMPS_REVERSE_SPEED_ML_PER_MIN = -30.0 to indicate that the direction is in reverse.

Wednesday 16 Jun 2021
9:36 pm

Dara Navaei

Done.

Done.

9:33 pm

Dara Navaei

Good catch, thanks. I changed it.

Good catch, thanks. I changed it.

9:32 pm

Dara Navaei

I check in the inlet pressure only at the states that are needed. There are times that I am not even pulling water from the inlet line.

I check in the inlet pressure only at the states that are needed. There are times that I am not even pulling water from the inlet line.

9:31 pm

Dara Navaei

It is no longer needed.

It is no longer needed.

9:27 pm

Dara Navaei

2000 uS/cm is a safe value to determine if the acid is inserted in. Due to sensor to sensor variations, we decided to keep it a little lower than its conductivity value is.

2000 uS/cm is a safe value to determine if the acid is inserted in. Due to sensor to sensor variations, we decided to keep it a little lower than its conductivity value is.

9:15 pm

Dara Navaei

Done.

Done.