dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 22 Jul 2021
9:21 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Addressed code review

Options
    • -1
    • +1
    ./Modes/ModeRecirculate.c
    • -4
    • +5
    ./Modes/ModeStandby.c
    • -0
    • +1
    ./Services/SystemComm.c
9:20 am

qnguyen  (deleted user)

Done.

Done.

9:20 am

qnguyen  (deleted user)

Done.

Done.

9:20 am

qnguyen  (deleted user)

Done.

Done.

9:18 am

qnguyen  (deleted user)

Done.

Done.

Wednesday 21 Jul 2021
10:36 pm

qnguyen  (deleted user)

VSP is never open until this state is done. The endSampleWaterRequest is for the user presses the stop button during the filter flush and end treatment, allowing DG to go back to standby idle state.

VSP is never open until this state is done.
The endSampleWaterRequest is for the user presses the stop button during the filter flush and end treatment, allowing DG to go back to standby idle state.

10:32 pm

qnguyen  (deleted user)

We have to flush the filter flush before user can request to sample water.

We have to flush the filter flush before user can request to sample water.

10:32 pm

qnguyen  (deleted user)

VSP should only be on when user requests to sample water.

VSP should only be on when user requests to sample water.

10:30 pm

qnguyen  (deleted user)

In DG standby mode, DG will transition to solo mode.

In DG standby mode, DG will transition to solo mode.

9:36 pm

Dara Navaei

Why is there a magic number here?

Why is there a magic number here?

9:29 pm

Dara Navaei

Add the doxygen comment.

Add the doxygen comment.

9:24 pm

Dara Navaei

fushLinesVolumeL is an input.

fushLinesVolumeL is an input.

9:21 pm

Dara Navaei

If HD is not communicating, should we got transition to standby solo mode?

If HD is not communicating, should we got transition to standby solo mode?

9:13 pm

Dara Navaei

Input: startSampleWaterRequest, endSampleWaterRequest.

Input: startSampleWaterRequest, endSampleWaterRequest.

9:13 pm

Dara Navaei

Output: startSampleWaterRequest, endSampleWaterRequest, waterSampleStartTime.

Output: startSampleWaterRequest, endSampleWaterRequest, waterSampleStartTime.

9:11 pm

Dara Navaei

This should be flush filter idle state.

This should be flush filter idle state.

9:09 pm

Dara Navaei

Why there is a endSampleWaterRequest in this state? We should never get here if sample water request is in place. Also, if this an endSampleWaterRequest here, VSP should be closed.

Why there is a endSampleWaterRequest in this state? We should never get here if sample water request is in place.
Also, if this an endSampleWaterRequest here, VSP should be closed.

9:04 pm

Dara Navaei

Should we turn on VSP?

Should we turn on VSP?

9:02 pm

Dara Navaei

Are we supposed to switch to water sample state? This does not go to water sample state.

Are we supposed to switch to water sample state? This does not go to water sample state.

8:26 pm

Dara Navaei

The getter from non-volatile module is in my branch.

The getter from non-volatile module is in my branch.

2:29 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Reduced tolerance on consecutive tare

Options
    • -9
    • +10
    ./Controllers/LoadCell.c
Tuesday 20 Jul 2021
10:12 pm

Dara Navaei

DG-DEN-9054_DG HD Switches
DG-DEN-9054_DG HD Switches
1:32 pm

Sean Nash

Why not alarm?

Why not alarm?

1:25 pm

Sean Nash

I think this is pretty clear, but for consistency, add a comment for this condition.

I think this is pretty clear, but for consistency, add a comment for this condition.

Monday 19 Jul 2021
4:27 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Implemented fill mode with new changes

Options
    • -30
    • +29
    ./Controllers/ConcentratePumps.c
    • -0
    • +1
    ./Controllers/ConcentratePumps.h
    • -18
    • +0
    ./Controllers/ConductivitySensors.c
    • -2
    • +0
    ./Controllers/ConductivitySensors.h
    • -1
    • +1
    ./Controllers/Heaters.c
    • -0
    • +1
    ./Modes/ModeDrain.c
    • -208
    • +221
    ./Modes/ModeFill.c
    • -0
    • +1
    ./Modes/ModeRecirculate.c
    • -0
    • +1
    ./Services/AlarmMgmt.c
    • -5
    • +5
    ./Services/Interrupts.c
Wednesday 14 Jul 2021
10:03 am

Dara Navaei

DEN-9054 updated the code

Options
    • -5
    • +124
    ./Controllers/ConcentratePumps.c
    • -0
    • +6
    ./Controllers/ConcentratePumps.h
    • -3
    • +1
    ./Controllers/ConductivitySensors.c
    • -4
    • +2
    ./Controllers/DrainPump.c
    • -103
    • +26
    ./Controllers/Fans.c
    • -91
    • +197
    ./Controllers/Heaters.c
    • -20
    • +25
    ./Controllers/LoadCell.c
    • -4
    • +2
    ./Controllers/Pressures.c
    • -15
    • +4
    ./Controllers/ROPump.c
    • -97
    • +103
    ./Controllers/TemperatureSensors.c
    • -90
    • +22
    ./Controllers/Thermistors.c
    • -1
    • +1
    ./Controllers/Voltages.h
    • -0
    • +1
    ./DGCommon.h
    • -5
    • +6
    ./Modes/ModeFill.c
    • -1
    • +5
    ./Modes/ModeHeatDisinfect.c
  16. … 19 more files in changeset.
Friday 09 Jul 2021
10:41 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
10:41 am

Dara Navaei

Enabled accelorometers

Options
    • -1
    • +1
    ./DGCommon.h
Wednesday 07 Jul 2021
12:16 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added delay to valves state change

Options
    • -2
    • +2
    ./Controllers/LoadCell.c
    • -13
    • +15
    ./Modes/ModeFault.c
    • -2
    • +8
    ./Services/Reservoirs.c
Saturday 03 Jul 2021
8:01 pm

pmontazemi  (deleted user)