Activity dgfirmware/firmware/App

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 23 Jul 2021

3:50 pm

Dara Navaei

More
1463d83
changed 5 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more DG-DEN-9054-1

DEN-9054 added messaging for service and serial number

- -2
- +3
./Services/Reservoirs.c
- History
- Source
- Diff
./Services/Reservoirs.c
- -0
- +5
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c
- -0
- +62
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -0
- +6
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h
… 1 more file in changeset.

10:39 am

Dara Navaei

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Dara Navaei

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Dara Navaei

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Dara Navaei

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Dara Navaei

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Dara Navaei

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Dara Navaei

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Dara Navaei

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

Sean Nash

More
Re: DG-DEN-7802-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:30 am

Sean Nash

More
Re: DG-DEN-7802-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 22 Jul 2021

11:37 am

Dara Navaei

More
97e0100
changed 17 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more DG-DEN-9054-1 DG-DEN-8886-1 DG-DEN-7802-1

DEN-9054 worked on POST functions. Changed the polarity direction of the watchdog expiration pin. Continued testing NV data mgmt

- -0
- +4
./Controllers/ConcentratePumps.c
- History
- Source
- Diff
./Controllers/ConcentratePumps.c
- -0
- +2
./Controllers/ConductivitySensors.c
- History
- Source
- Diff
./Controllers/ConductivitySensors.c
- -0
- +2
./Controllers/DrainPump.c
- History
- Source
- Diff
./Controllers/DrainPump.c
- -1
- +1
./Controllers/Fans.c
- History
- Source
- Diff
./Controllers/Fans.c
- -1
- +1
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c
- -0
- +2
./Controllers/LoadCell.c
- History
- Source
- Diff
./Controllers/LoadCell.c
- -0
- +3
./Controllers/Pressures.c
- History
- Source
- Diff
./Controllers/Pressures.c
- -0
- +3
./Controllers/ROPump.c
- History
- Source
- Diff
./Controllers/ROPump.c
- -2
- +4
./Controllers/TemperatureSensors.c
- History
- Source
- Diff
./Controllers/TemperatureSensors.c
- -3
- +1
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h
- -1
- +1
./Drivers/CPLD.c
- History
- Source
- Diff
./Drivers/CPLD.c
- -7
- +8
./Modes/ModeInitPOST.c
- History
- Source
- Diff
./Modes/ModeInitPOST.c
- -1
- +1
./Services/FPGA.c
- History
- Source
- Diff
./Services/FPGA.c
- -0
- +2
./Services/Reservoirs.c
- History
- Source
- Diff
./Services/Reservoirs.c
- -2
- +2
./Services/WatchdogMgmt.c
- History
- Source
- Diff
./Services/WatchdogMgmt.c
… 2 more files in changeset.

10:56 am

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Sean Nash

Added back alarm.

Added back alarm.

9:21 am

Quang Nguyen <qnguyen@diality.com>

More
5291bb3
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more DG-DEN-7802-1

DEN-7802: Addressed code review

- -1
- +1
./Modes/ModeRecirculate.c
- History
- Source
- Diff
./Modes/ModeRecirculate.c
- -4
- +5
./Modes/ModeStandby.c
- History
- Source
- Diff
./Modes/ModeStandby.c
- -0
- +1
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c

9:20 am

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Dara Navaei

Done.

Done.

9:20 am

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Dara Navaei

Done.

Done.

9:20 am

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Dara Navaei

Done.

Done.

9:18 am

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Dara Navaei

Done.

Done.

Wednesday 21 Jul 2021

10:36 pm

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Dara Navaei

VSP is never open until this state is done. The endSampleWaterRequest is for the user presses the stop button during the filter flush and end treatment, allowing DG to go back to standby idle state.

VSP is never open until this state is done.
The endSampleWaterRequest is for the user presses the stop button during the filter flush and end treatment, allowing DG to go back to standby idle state.

10:32 pm

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Dara Navaei

We have to flush the filter flush before user can request to sample water.

We have to flush the filter flush before user can request to sample water.

10:32 pm

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Dara Navaei

VSP should only be on when user requests to sample water.

VSP should only be on when user requests to sample water.

10:30 pm

qnguyen (deleted user)

More
Re: DG-DEN-7802-1
replied to Dara Navaei

In DG standby mode, DG will transition to solo mode.

In DG standby mode, DG will transition to solo mode.

9:36 pm

Dara Navaei

More
Re: DG-DEN-7802-1
commented on review

Why is there a magic number here?

Why is there a magic number here?

9:29 pm

Dara Navaei

More
Re: DG-DEN-7802-1
commented on review

Add the doxygen comment.

Add the doxygen comment.

9:24 pm

Dara Navaei

More
Re: DG-DEN-7802-1
commented on review

fushLinesVolumeL is an input.

fushLinesVolumeL is an input.

9:21 pm

Dara Navaei

More
Re: DG-DEN-7802-1
commented on review

If HD is not communicating, should we got transition to standby solo mode?

If HD is not communicating, should we got transition to standby solo mode?

9:13 pm

Dara Navaei

More
Re: DG-DEN-7802-1
commented on review

Input: startSampleWaterRequest, endSampleWaterRequest.

Input: startSampleWaterRequest, endSampleWaterRequest.

9:13 pm

Dara Navaei

More
Re: DG-DEN-7802-1
commented on review

Output: startSampleWaterRequest, endSampleWaterRequest, waterSampleStartTime.

Output: startSampleWaterRequest, endSampleWaterRequest, waterSampleStartTime.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-08 13:59 -0700