dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Jul 2021
3:49 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added checks for alarm priority table

Options
    • -0
    • +3
    ./Services/AlarmMgmt.c
  2. … 1 more file in changeset.
1:26 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:16 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:13 pm

qnguyen  (deleted user)

Need to have 2 blank lines.

Need to have 2 blank lines.

1:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:24 pm

qnguyen  (deleted user)

Need to add a check if switchId is in valid range.

Need to add a check if switchId is in valid range.

12:23 pm

qnguyen  (deleted user)

Do we need to add copyrights or bamboo will do it?

Do we need to add copyrights or bamboo will do it?

12:20 pm

qnguyen  (deleted user)

Common has an enumeration (OPN_CLS_STATE_T) that is similar to this. Suggest using from common.

Common has an enumeration (OPN_CLS_STATE_T) that is similar to this. Suggest using from common.

12:14 pm

qnguyen  (deleted user)

Should this function move to ModeRecirculate? It does not seem to contain any information related to drain pump.

Should this function move to ModeRecirculate? It does not seem to contain any information related to drain pump.

12:13 pm

qnguyen  (deleted user)

What happens when calibration data is invalid?

What happens when calibration data is invalid?

12:09 pm

qnguyen  (deleted user)

The comment is out-date and need to be updated.

The comment is out-date and need to be updated.

12:05 pm

qnguyen  (deleted user)

Param name is not matched.

Param name is not matched.

12:05 pm

qnguyen  (deleted user)

This can fit in one line.

This can fit in one line.

11:34 am

qnguyen  (deleted user)

Should it be 0 and is the first one in the enumeration?

Should it be 0 and is the first one in the enumeration?

9:54 am

Dara Navaei

DEN-9054 addressed code review comments

Options
    • -14
    • +9
    ./Controllers/Switches.c
    • -4
    • +48
    ./Services/FPGA.c
    • -1
    • +5
    ./Services/FPGA.h
    • -1
    • +1
    ./Services/SystemCommMessages.c
9:07 am

Dara Navaei

Done.

Done.

Wednesday 28 Jul 2021
8:58 pm

Dara Navaei

DEN-9054 addressed the code review comments

Options
    • -1
    • +1
    ./Controllers/ConductivitySensors.c
    • -11
    • +0
    ./Controllers/Pressures.c
    • -52
    • +58
    ./Controllers/Switches.c
  4. … 2 more files in changeset.
8:54 pm

Dara Navaei

This is fixed in the latest commit.

This is fixed in the latest commit.

8:46 pm

Dara Navaei

Done.

Done.

8:45 pm

Dara Navaei

The default pump control mode is none.

The default pump control mode is none.

8:44 pm

Dara Navaei

Done.

Done.

8:09 pm

Dara Navaei

Done.

Done.

8:07 pm

Dara Navaei

Done.

Done.

8:06 pm

Dara Navaei

Done.

Done.

8:04 pm

Dara Navaei