Activity dgfirmware/firmware/App

10:51 am

Dara Navaei

More
ddd2e12
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more DG-DEN-9480-1

DEN-9480 updated documentation

- -1
- +1
./Controllers/Pressures.c
- History
- Source
- Diff
./Controllers/Pressures.c
- -1
- +1
./Controllers/Valves.c
- History
- Source
- Diff
./Controllers/Valves.c
- -2
- +2
./Services/Reservoirs.c
- History
- Source
- Diff
./Services/Reservoirs.c

10:37 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

10:36 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

10:36 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

10:35 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

9:08 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

Done.

9:07 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

The const is an optional step in our code. Plus these are the local variables and their values are not changed inside the function.

9:05 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

Done.

9:04 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

Done.

5:37 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

Variable reservoirDataPublicationTimerCounter is missing in the @detail Inputs and Output

3:38 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

I am not sure why you removed the "const" from dialysateTemp and targetTemp?

3:20 pm

Dara Navaei

More
892c83e
changed 1 file
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h

3:08 pm

Sean Nash

More
860cbde
changed 3 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merge branch 'DEN-9906-hd_dev-flow-measurement-changes' into develop

- -0
- +6
./Modes/ModeInitPOST.c
- History
- Source
- Diff
./Modes/ModeInitPOST.c
- -26
- +0
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -3
- +0
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h

3:07 pm

Dara Navaei

More
ce20c15
changed 5 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more DG-DEN-9906-1

DEN-9906 added self test for the dialysate flow sensor and removed its broadcast function

- -2
- +29
./Controllers/DialysateFlow.c
- History
- Source
- Diff
./Controllers/DialysateFlow.c
- -0
- +2
./Controllers/DialysateFlow.h
- History
- Source
- Diff
./Controllers/DialysateFlow.h
- -0
- +6
./Modes/ModeInitPOST.c
- History
- Source
- Diff
./Modes/ModeInitPOST.c
- -26
- +0
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -3
- +0
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h

2:35 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

Added "pressuresDataPublicationTimerCounter" variable to @details Outputs

2:29 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

The state variable valvesStatesPublicationTimerCounter was read, increment, then write. Therefore, it needs to be added to the @details Outputs.

2:15 pm

Sean Nash

More
2bdae96
changed 4 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Fixed merge conflicts. Fixed launch change.

- -0
- +4
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c
- -0
- +25
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -0
- +3
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h
… 1 more file in changeset.

2:14 pm

Dara Navaei

More
ee2f811
changed 1 file
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h

2:14 pm

Hung Nguyen <hnguyen@diality.com>

More
4130366
changed 3 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merged dialysate flow sensor calibration

- -14
- +33
./Controllers/DialysateFlow.c
- History
- Source
- Diff
./Controllers/DialysateFlow.c
- -0
- +1
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c
… 1 more file in changeset.

1:35 pm

Sean Nash

More
92d1230
changed 5 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more DG-DEN-9906-1

DEN-9906: DIAL-138 - Added DG alarm condition status and Dialin cmd to clear all DG alarms.

- -0
- +42
./Services/AlarmMgmt.c
- History
- Source
- Diff
./Services/AlarmMgmt.c
- -0
- +1
./Services/AlarmMgmt.h
- History
- Source
- Diff
./Services/AlarmMgmt.h
- -0
- +4
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c
- -0
- +25
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -0
- +3
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h

12:55 pm

Hung Nguyen <hnguyen@diality.com>

More
66c7171
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more DG-DEN-9906-1

DEN-9906 Removed code added to collect unfiltered dialysate flow data

- -3
- +1
./Controllers/DialysateFlow.c
- History
- Source
- Diff
./Controllers/DialysateFlow.c

11:17 am

Sean Nash

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

11:15 am

Sean Nash

More
Re: DG-DEN-9906-1
commented on review

Need to range check flow.

11:10 am

Sean Nash

More
Re: DG-DEN-9906-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

11:09 am

Dara Navaei

More
45902a4
changed 2 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more DG-DEN-9480-1

DEN-9480 addressed the code review comments

- -0
- +1
./Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
./Services/AlarmMgmtSWFaults.h
- -1
- +1
./Services/Interrupts.c
- History
- Source
- Diff
./Services/Interrupts.c

11:09 am

hnguyen (deleted user)

More
Re: DG-DEN-9906-1
replied to Sean Nash

I removed the alarm.

11:09 am

Dara Navaei

More
Re: DG-DEN-9480-1
replied to Sean Nash

Done.

11:06 am

Dara Navaei

More
Re: DG-DEN-9480-1
replied to Sean Nash

Removed it.

11:02 am

Sean Nash

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

App

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

hnguyen (deleted user)

hnguyen (deleted user)

hnguyen (deleted user)

hnguyen (deleted user)

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

hnguyen (deleted user)

hnguyen (deleted user)

Dara Navaei

Sean Nash

Dara Navaei

hnguyen (deleted user)

hnguyen (deleted user)

Sean Nash

Dara Navaei

Hung Nguyen <hnguyen@diality.com>

Sean Nash

Hung Nguyen <hnguyen@diality.com>

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

hnguyen (deleted user)

Dara Navaei

Dara Navaei

Sean Nash