dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 23 May 2022
2:41 pm

Dara Navaei

DEN-12224 addressed the code review comments

Options
    • -2
    • +1
    ./Controllers/ConcentratePumps.c
    • -2
    • +2
    ./Controllers/ConcentratePumps.h
    • -2
    • +1
    ./Controllers/ConductivitySensors.c
    • -0
    • +1
    ./Controllers/DialysateFlow.c
    • -1
    • +0
    ./Controllers/FluidLeak.c
    • -1
    • +0
    ./Controllers/FluidLeak.h
    • -62
    • +17
    ./Controllers/Heaters.c
    • -1
    • +0
    ./Controllers/Pressures.c
    • -1
    • +0
    ./Controllers/Switches.c
    • -1
    • +1
    ./Controllers/Switches.h
    • -2
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -3
    • +2
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Modes/ModeGenIdle.c
    • -18
    • +18
    ./Modes/ModeHeatDisinfect.c
    • -4
    • +3
    ./Modes/ModeStandby.c
  16. … 5 more files in changeset.
2:40 pm

Dara Navaei

Done.

Done.

2:40 pm

Dara Navaei

Yes we will further test this in DVT.

Yes we will further test this in DVT.

2:39 pm

Dara Navaei

Done.

Done.

2:38 pm

Dara Navaei

Done.

Done.

2:37 pm

Dara Navaei

Done.

Done.

2:36 pm

Dara Navaei

Done.

Done.

2:35 pm

Dara Navaei

Done.

Done.

2:35 pm

Dara Navaei

Done.

Done.

2:34 pm

Dara Navaei

Done.

Done.

2:34 pm

Dara Navaei

Done.

Done.

2:31 pm

Dara Navaei

I added another item to be initialized but some of them are related to turning of the heater when there is no flow that are removed.

I added another item to be initialized but some of them are related to turning of the heater when there is no flow that are removed.

2:20 pm

Dara Navaei

The fault has been implemented. As soon as all of the testing is done, I will remove this code.

The fault has been implemented. As soon as all of the testing is done, I will remove this code.

2:19 pm

Dara Navaei

Done.

Done.

2:18 pm

Dara Navaei

Yes it is one of the POST states of the NV data management.

Yes it is one of the POST states of the NV data management.

2:17 pm

Dara Navaei

They should not be switches. They are all caps.

They should not be switches. They are all caps.

2:15 pm

Dara Navaei

Done.

Done.

2:15 pm

Dara Navaei

Done.

Done.

2:13 pm

Dara Navaei

When the NV record data is requested, the number of sensors to be checked has to be provided for error check. But this is not a sensor so 0 is passed. I defined a variable for it to be readable.

When the NV record data is requested, the number of sensors to be checked has to be provided for error check. But this is not a sensor so 0 is passed. I defined a variable for it to be readable.

2:08 pm

Dara Navaei

Done.

Done.

2:07 pm

Dara Navaei

Removed the blank lines.

Removed the blank lines.

2:06 pm

Dara Navaei

Done.

Done.

2:05 pm

Dara Navaei

hdMode is initialized now.

hdMode is initialized now.

2:03 pm

Dara Navaei

Done.

Done.

2:01 pm

Dara Navaei

Done.

Done.

2:00 pm

Dara Navaei

Done.

Done.

1:59 pm

Dara Navaei

Done.

Done.

1:57 pm

Dara Navaei

Done.

Done.

1:56 pm

Dara Navaei

Done.

Done.

1:56 pm

Dara Navaei

Done.

Done.