dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Jun 2022
3:48 pm

Darren Cox <darren_m@cox.net>

DEN-12847 Code review comments update.

Options
    • -3
    • +0
    ./Controllers/LoadCell.c
3:44 pm

dcox  (deleted user)

Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.

Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.

3:43 pm

dcox  (deleted user)

10-20 seems like a better number, but my sample size is small so I did not change it.

10-20 seems like a better number, but my sample size is small so I did not change it.

3:42 pm

dcox  (deleted user)

Updated

Updated

3:41 pm

dcox  (deleted user)

Updated

Updated

2:32 pm

Darren Cox <darren_m@cox.net>

DEN-12847 Code review comments update.

Options
    • -7
    • +10
    ./Controllers/LoadCell.c
2:10 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974 Code review updates

Options
    • -1
    • +1
    ./Controllers/ConductivitySensors.c
    • -1
    • +0
    ./Controllers/ROPump.c
11:01 am

wbracken  (deleted user)

Seems like isADCValid should be returned.

Seems like isADCValid should be returned.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

10:41 am

wbracken  (deleted user)

Removed blank line

Removed blank line

10:38 am

wbracken  (deleted user)

Will add back in.

Will add back in.

9:27 am

Sean Nash

Are we sticking with this threshold?

Are we sticking with this threshold?

9:26 am

Sean Nash

Need to address TODOs. Have we assessed what an appropriate max delta should be? Alarm should be cleared if it is recoverable (not a fault) and not cleared immediately (see alarm properties).

Need to address TODOs. Have we assessed what an appropriate max delta should be? Alarm should be cleared if it is recoverable (not a fault) and not cleared immediately (see alarm properties).

9:24 am

Sean Nash

Make this assignment explicitly BOOL (i.e. TRUE or FALSE), not implied bool.

Make this assignment explicitly BOOL (i.e. TRUE or FALSE), not implied bool.

9:23 am

Sean Nash

Use our boolean #define (FALSE) instead of built-in (false).

Use our boolean #define (FALSE) instead of built-in (false).

9:06 am

Sean Nash

Remove blank line.

Remove blank line.

9:06 am

Sean Nash

Coding standard wants just one return statement in a function. Set a local boolean in if/else and return that.

Coding standard wants just one return statement in a function. Set a local boolean in if/else and return that.

9:01 am

Sean Nash

Should we return isADCValid? Pick one, remove the other.

Should we return isADCValid? Pick one, remove the other.

8:59 am

Sean Nash

Can we remove this code now?

Can we remove this code now?

8:59 am

Sean Nash

Why is this commented out?

Why is this commented out?

8:58 am

Sean Nash

Can we just remove this code now?

Can we just remove this code now?

8:58 am

Sean Nash

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

8:56 am

Sean Nash

Why is this alarm commented out?

Why is this alarm commented out?

8:55 am

Sean Nash

I think we need two separate minimums here. 1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name. 2. used by UVReactors.c should be 0.3 and private (declared in UVRea...

I think we need two separate minimums here.
1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name.
2. used by UVReactors.c should be 0.3 and private (declared in UVReactors.c) with a different name like MIN_RO_FLOW_FOR_UV_LPM.

8:51 am

Sean Nash

Remove extra blank line.

Remove extra blank line.