dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 22 Jul 2022
1:30 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13549 Correct reservoir volume logic to match requirements. Changed ">" to ">=" in several modes when checking for R1 being filled before R2

Options
    • -3
    • +3
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeFlush.c
    • -2
    • +2
    ./Modes/ModeHeatDisinfect.c
10:37 am

Sean Nash

Should be s/w fault. Add TODO or trigger s/w fault now.

Should be s/w fault. Add TODO or trigger s/w fault now.

10:36 am

Sean Nash

Blank line between declarations and code.

Blank line between declarations and code.

10:34 am

Sean Nash

This assignment should be done above at declaration. Move calStatus declaration above result.

This assignment should be done above at declaration. Move calStatus declaration above result.

10:31 am

Sean Nash

Keep this blank line.

Keep this blank line.

10:17 am

Sean Nash

Do either of these 2 if statements need an else?

Do either of these 2 if statements need an else?

10:15 am

Sean Nash

Blank line between declarations and code.

Blank line between declarations and code.

10:12 am

Sean Nash

Prefer normal if else for calling functions. I see these throughout.

Prefer normal if else for calling functions. I see these throughout.

10:01 am

Sean Nash

DEN-13460: Changed FPGA POST to check compatibility rev instead of FPGA version.

Options
    • -10
    • +3
    ./Services/FPGA.c
9:46 am

Dara Navaei

DEN-13460 updated the DVT FPGA registers

Options
    • -2
    • +3
    ./Services/FPGA.c
9:04 am

Sean Nash

What is the point in having these locals? Why not just use the concentratePumps fields directly?

What is the point in having these locals? Why not just use the concentratePumps fields directly?

9:01 am

Sean Nash

This blank line should stay - style is to have blank lines between declarations and code.

This blank line should stay - style is to have blank lines between declarations and code.

9:00 am

Sean Nash

Define disable (even if not used) so it is clear which bit position controls enable/disable.

Define disable (even if not used) so it is clear which bit position controls enable/disable.

Thursday 21 Jul 2022
1:53 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
10:54 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
10:53 am

Dara Navaei

Merge branch 'develop' of ssh://dvm-linux02:7999/dg/dgfirmware into develop

Options
    • -3
    • +3
    ./Controllers/ROPump.c
10:53 am

Dara Navaei

Merged DEN-13460

Options
    • -39
    • +40
    ./Controllers/Heaters.c
    • -13
    • +43
    ./Controllers/LoadCell.c
    • -6
    • +6
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
    • -0
    • +3
    ./Services/SystemCommMessages.c
10:51 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
10:48 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-12974-miscellaneous-flush-issues_bb' into develop

Options
    • -3
    • +3
    ./Controllers/ROPump.c
10:47 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974 DEN-13242 Allow RO target flow rate to be set to 0 to support V&V testing.

Options
    • -3
    • +3
    ./Controllers/ROPump.c
10:46 am

Dara Navaei

DEN-13460 updated the code with the DVT changes

Options
    • -1
    • +2
    ./Controllers/DialysateFlow.c
    • -0
    • +317
    ./Controllers/FlowSensors.c
    • -0
    • +55
    ./Controllers/FlowSensors.h
    • -28
    • +33
    ./Controllers/Heaters.c
    • -5
    • +5
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
    • -4
    • +34
    ./Services/FPGA.c
    • -0
    • +3
    ./Services/FPGA.h
    • -0
    • +3
    ./Tasks/TaskPriority.c
Tuesday 19 Jul 2022
8:19 pm

Dara Navaei

DEN-13460 updated the drivers with the DVT changes.

Options
    • -1
    • +1
    ./Controllers/DialysateFlow.c
    • -11
    • +7
    ./Controllers/Heaters.c
    • -54
    • +5
    ./Controllers/Pressures.c
    • -1
    • +1
    ./Controllers/ROPump.c
    • -15
    • +14
    ./Controllers/Voltages.c
    • -3
    • +3
    ./Drivers/InternalADC.c
    • -30
    • +32
    ./Services/FPGA.c
4:11 pm

Sean Nash

DEN-13460: Added blank fields for alarm priority, rank and clear top only on alarm trigger messages for DG.

Options
    • -0
    • +3
    ./Services/SystemCommMessages.c
Monday 18 Jul 2022
8:53 pm

Dara Navaei

DEN-13460 merged staging

Options
    • -13
    • +43
    ./Controllers/LoadCell.c
    • -1
    • +1
    ./DGCommon.h
6:12 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
6:11 pm

Dara Navaei

Merge branch 'DEN-13427-sw_dev-sprint-75_mg' into develop

Options
    • -1
    • +1
    ./Controllers/LoadCell.c
6:11 pm

Dara Navaei

DEN-13427 fixed load cell tare

Options
    • -1
    • +1
    ./Controllers/LoadCell.c
4:50 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
4:47 pm

Dara Navaei

Removed debug_denali

Options
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
4:17 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h