dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 30 Aug 2022
3:03 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
3:02 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-13786-hd_dg_dev-s78_bb' into develop

# Conflicts:

# firmware/App/Controllers/DialysateFlow.c

Options
    • -1
    • +6
    ./Controllers/TemperatureSensors.c
2:53 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13786 DEN-13770 The persistent alarm interface was changed resulting in the immediate turning off of the UVReactors. Changed to correct function call. DEN-13786 DEN-13558 Correct getRsrvrDrainStatus and getRsrvrFillStatus per modes to Flush mode

Options
    • -2
    • +2
    ./Controllers/UVReactors.c
    • -4
    • +24
    ./Modes/ModeHeatDisinfect.c
2:33 pm

Sean Nash

DEN-13460: make boolean explicit, update function header.

Options
    • -1
    • +3
    ./Controllers/LoadCell.c
10:21 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
10:21 am

Dara Navaei

Commented out alarm 196

Options
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
Monday 29 Aug 2022
5:08 pm

wbracken  (deleted user)

Align on "*" maybe?

Align on "*" maybe?

4:38 pm

wbracken  (deleted user)

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the sema...

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.

4:31 pm

wbracken  (deleted user)

Should this function handle invalid hex characters?

Should this function handle invalid hex characters?

3:57 pm

wbracken  (deleted user)

Set "status" to FALSE.

Set "status" to FALSE.

3:51 pm

wbracken  (deleted user)

Should this be removed?

Should this be removed?

3:47 pm

wbracken  (deleted user)

Should variables in if be reversed?

Should variables in if be reversed?

3:42 pm

wbracken  (deleted user)

Should this be in or not?

Should this be in or not?

2:56 pm

wbracken  (deleted user)

Some values have "U"?

Some values have "U"?

2:49 pm

wbracken  (deleted user)

Are we moving away from initializing via definition?

Are we moving away from initializing via definition?

1:10 pm

Sean Nash

DEN-13460: Fixed bug DEN-13777.

Options
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeFlush.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
9:57 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
9:57 am

Dara Navaei

Merged DEN-13460

Options
    • -2
    • +2
    ./Controllers/ConductivitySensors.c
    • -11
    • +16
    ./Controllers/Heaters.c
    • -46
    • +47
    ./Controllers/ROPump.c
    • -2
    • +2
    ./Controllers/ROPump.h
    • -96
    • +23
    ./Controllers/TemperatureSensors.c
    • -1
    • +0
    ./DGCommon.h
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
Sunday 28 Aug 2022
6:49 pm

Dara Navaei

DEN-13460 updated the FPGA persistent alarm functions

Options
    • -3
    • +0
    ./Controllers/DrainPump.c
    • -25
    • +24
    ./Controllers/ROPump.c
    • -96
    • +23
    ./Controllers/TemperatureSensors.c
    • -1
    • +0
    ./DGCommon.h
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
2:32 pm

Dara Navaei

DEN-13460 updated the trimmer heater's duty cycle cap control

Options
    • -9
    • +14
    ./Controllers/Heaters.c
    • -16
    • +18
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
    • -63
    • +68
    ./Controllers/Voltages.c
    • -0
    • +8
    ./Services/FPGA.c
Friday 26 Aug 2022
4:07 pm

wbracken  (deleted user)

Remove comment.

Remove comment.

1:40 pm

dcox  (deleted user)

When will it be uncommented?

When will it be uncommented?

1:38 pm

dcox  (deleted user)

U64 implies Unsigned, but this is signed.

U64 implies Unsigned, but this is signed.

12:24 pm

dcox  (deleted user)

Remove todo in comment if it is resolved.

Remove todo in comment if it is resolved.

12:18 pm

dcox  (deleted user)

No comment to explain why it is all commented.

No comment to explain why it is all commented.

9:17 am

Dara Navaei

DEN-13460 merged staging

Options
    • -9
    • +10
    ./Controllers/ConductivitySensors.c
    • -1
    • +1
    ./Controllers/DialysateFlow.c
    • -4
    • +4
    ./Controllers/DrainPump.c
    • -2
    • +3
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Controllers/ROPump.c
    • -3
    • +3
    ./Controllers/ROPump.h
    • -1
    • +1
    ./DGCommon.h
    • -34
    • +35
    ./Modes/ModeChemicalDisinfect.c
    • -38
    • +73
    ./Modes/ModeFlush.c
    • -46
    • +50
    ./Modes/ModeHeatDisinfect.c
9:14 am

Dara Navaei

DEN-13460 updated the RO pump duty cycle feedback

Options
    • -4
    • +4
    ./Controllers/ROPump.c
Thursday 25 Aug 2022
6:10 pm

Dara Navaei

DG-DEN-13598_DG HD Dev Sprint 77 FW Dong
DG-DEN-13598_DG HD Dev Sprint 77 FW Dong
5:43 pm

Sean Nash

Send functions usually return a BOOL.

Send functions usually return a BOOL.

5:41 pm

Sean Nash

Remove blank line.

Remove blank line.