dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Nov 2022
2:19 pm

Michael Garthwaite

DEN-14197: Addressed code review comments.

Options
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
    • -5
    • +6
    ./Services/PIControllers.c
2:19 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:19 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:18 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:18 pm

Sean Nash

Dara confirmed it is a duty cycle. We expect it to match our commanded duty cycle for the pump.

Dara confirmed it is a duty cycle. We expect it to match our commanded duty cycle for the pump.

2:17 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:10 pm

wbracken  (deleted user)

Alignment

Alignment

2:10 pm

Sean Nash

Do we need a maximum? If so, magic number.

Do we need a maximum? If so, magic number.

2:09 pm

Sean Nash

Invalid step limit (not signal)?

Invalid step limit (not signal)?

2:07 pm

Sean Nash

We are changing the step limit on a control so I would expect an output.

We are changing the step limit on a control so I would expect an output.

2:06 pm

Sean Nash

Remove signalID and add stepLimit as params.

Remove signalID and add stepLimit as params.

2:04 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:04 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:04 pm

Michael Garthwaite

DEN-14197: Addressed code review comments.

Options
    • -17
    • +8
    ./Services/PIControllers.c
    • -1
    • +0
    ./Services/PIControllers.h
2:02 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:02 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:02 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:01 pm

Michael Garthwaite

Yes and no for the place holder. The profiles expected to change in the future. They may have different load states but for now we have tuned Kp and Ki along with our maximum PWM step limit to get ...

Yes and no for the place holder. The profiles expected to change in the future. They may have different load states but for now we have tuned Kp and Ki along with our maximum PWM step limit to get the level of responsiveness we wanted to achieve with this optimization task. We can further fine tune the pump profiles with this data structure if necessary. setROPIFlowProfile will be called in when we transition operation modes when we intend to differentiate between profiles.

2:01 pm

Sean Nash

Remove blank line.

Remove blank line.

2:00 pm

Sean Nash

Based on function name, this function only expects to change step limit. So shouldn't need to pass signalID as param and shouldn't need a switch.

Based on function name, this function only expects to change step limit. So shouldn't need to pass signalID as param and shouldn't need a switch.

2:00 pm

wbracken  (deleted user)

Alignment

Alignment

2:00 pm

wbracken  (deleted user)

Remove blank line

Remove blank line

1:58 pm

wbracken  (deleted user)

Alignment

Alignment

1:57 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:57 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:56 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!