dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 3
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 20 Dec 2022
12:44 pm

Steve Jarpe <sjarpe@diality.com>

DEN-14316-chemical-disinfect. Merged code walkthrough changes and my code review changes.

Options
    • -33
    • +34
    ./Modes/ModeChemicalDisinfect.c
    • -33
    • +31
    ./Modes/ModeChemicalDisinfectFlush.c
    • -2
    • +1
    ./Modes/ModeChemicalDisinfectFlush.h
    • -3
    • +3
    ./Modes/ModeStandby.c
    • -1
    • +1
    ./Modes/OperationModes.c
    • -1
    • +1
    ./Services/PIControllers.h
    • -2
    • +2
    ./Services/SystemCommMessages.c
12:40 pm

Steve Jarpe

The start_stop messages for other modes are named similarly.

The start_stop messages for other modes are named similarly.

12:35 pm

Steve Jarpe

removed

removed

12:35 pm

Steve Jarpe

removed

removed

12:29 pm

Steve Jarpe

fixed

fixed

12:28 pm

Steve Jarpe

fixed

fixed

12:25 pm

Steve Jarpe

Fixed

Fixed

12:21 pm

Steve Jarpe

fixed

fixed

12:19 pm

Steve Jarpe

fixed

fixed

12:17 pm

Steve Jarpe

I need help with resolving this.

I need help with resolving this.

12:08 pm

Steve Jarpe

I am still not sure where you want the declarations to go. They are just before the part of the function that checks the inlet water conditions. The only other logical place is at the top.

I am still not sure where you want the declarations to go. They are just before the part of the function that checks the inlet water conditions. The only other logical place is at the top.

12:01 pm

Steve Jarpe

Removed the do nothing cases, added comment to default case.

Removed the do nothing cases, added comment to default case.

11:57 am

Steve Jarpe

Fixed

Fixed

11:03 am

Sean Nash

11:01 am

Steve Jarpe <sjarpe@diality.com>

DEN-14316-chemical-disinfect. Changes for code review

Options
    • -35
    • +40
    ./Modes/ModeChemicalDisinfect.c
    • -25
    • +24
    ./Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +17
    ./Modes/ModeChemicalDisinfectFlush.h
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
10:36 am

Dara Navaei

DEN-14307 updated the concentrate pumps park command

Options
    • -21
    • +55
    ./Controllers/ConcentratePumps.c
    • -32
    • +24
    ./Modes/ModeHeatDisinfect.c
10:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Sean Nash

Not necessarily at top of function. If variables are only used in a smaller scope (e.g. an if body), they can be declared at the top of that scope. I prefer they not be declared in the middle of co...

Not necessarily at top of function. If variables are only used in a smaller scope (e.g. an if body), they can be declared at the top of that scope. I prefer they not be declared in the middle of code unless there is a good reason (e.g. a dependency in assignment on code above).

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

DEN-14316: Replaced tabs with 4 spaces per code review.

Options
    • -32
    • +32
    ./Modes/ModeChemicalDisinfectFlush.c
9:52 am

Sean Nash

Align "="s.

Align "="s.

9:51 am

Sean Nash

Alignment - why is "=" pushed out so far?

Alignment - why is "=" pushed out so far?

9:46 am

Sean Nash

Align "="s.

Align "="s.

9:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.