dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 11 Jan 2023
10:32 am

Dara Navaei

Merge branch 'staging' into DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7

Options
    • -1
    • +1
    ./Controllers/ConductivitySensors.c
    • -1
    • +1
    ./Controllers/ConductivitySensors.h
    • -1
    • +1
    ./Controllers/DrainPump.c
    • -2
    • +4
    ./Controllers/DrainPump.h
    • -1
    • +1
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Controllers/Heaters.h
    • -1
    • +1
    ./Controllers/Pressures.c
    • -1
    • +1
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Controllers/ROPump.h
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Controllers/Voltages.h
    • -1
    • +1
    ./Drivers/CPLD.h
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    ./Modes/ModeDrain.c
  16. … 9 more files in changeset.
10:32 am

Dara Navaei

DEN-14497 addressed the code review comments

Options
    • -12
    • +17
    ./Controllers/DrainPump.c
    • -4
    • +4
    ./Controllers/Heaters.c
    • -2
    • +1
    ./Controllers/ROPump.c
    • -2
    • +2
    ./Controllers/Voltages.h
    • -10
    • +17
    ./Modes/ModeChemicalDisinfect.c
    • -7
    • +14
    ./Modes/ModeChemicalDisinfectFlush.c
    • -6
    • +12
    ./Modes/ModeHeatDisinfect.c
10:32 am

Dara Navaei

Done

Done

10:30 am

Dara Navaei

It is aligned.

It is aligned.

10:30 am

Dara Navaei

Done

Done

10:27 am

Dara Navaei

Done

Done

10:26 am

Dara Navaei

Done

Done

10:25 am

Dara Navaei

Yes, it has been updated.

Yes, it has been updated.

10:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:08 am

Dara Navaei

Done

Done

10:06 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:06 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:04 am

Dara Navaei

No, the thresholds are the same except the cleaning modes fault.

No, the thresholds are the same except the cleaning modes fault.

10:04 am

Dara Navaei

Made them different.

Made them different.

9:40 am

Dara Navaei

No, the thresholds are the same except in the cleaning modes we fault.

No, the thresholds are the same except in the cleaning modes we fault.

9:39 am

Dara Navaei

No, the thresholds are the same except in the cleaning modes we fault and in the treatment modes we recover if possible.

No, the thresholds are the same except in the cleaning modes we fault and in the treatment modes we recover if possible.

9:38 am

Dara Navaei

Done

Done

9:38 am

Dara Navaei

Done

Done

9:38 am

Dara Navaei

Done

Done

9:37 am

Dara Navaei

Done

Done

9:37 am

Dara Navaei

Done

Done

9:37 am

Dara Navaei

Done

Done

9:37 am

Dara Navaei

Done

Done

9:36 am

Dara Navaei

Done

Done

9:34 am

Dara Navaei

Done

Done

9:34 am

Dara Navaei

Done

Done

9:33 am

Dara Navaei

Done

Done

9:31 am

Dara Navaei

Done

Done

9:28 am

Dara Navaei

Done

Done

Tuesday 10 Jan 2023
6:13 pm

Sean Nash

Keep blank line between declarations and code.

Keep blank line between declarations and code.