dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Feb 2023
11:07 am

Dara Navaei

DEN-14604 added VectorCAST from PiSquare and addressed code review comments

Options
    • -1
    • +1
    ./Controllers/Pressures.c
    • -0
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -29
    • +27
    ./Modes/ModeHeatDisinfect.c
10:55 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Dara Navaei

Done

Done

10:32 am

Dara Navaei

Done

Done

10:21 am

Sean Nash

The enum comments are now non-doxygen style, but the enum is still in the group. Move it below the /*@}/ to get it out of HeatersState group.

The enum comments are now non-doxygen style, but the enum is still in the group. Move it below the /*@}/ to get it out of HeatersState group.

10:20 am

Dara Navaei

Done

Done

10:20 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:15 am

Sean Nash

Shouldn't this one stay "MIN"?

Shouldn't this one stay "MIN"?

10:12 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:12 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:12 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:08 am

Dara Navaei

DEN-14604 addressed the code review comments

Options
    • -1
    • +1
    ./Controllers/UVReactors.c
    • -24
    • +19
    ./Modes/ModeChemicalDisinfect.c
    • -19
    • +18
    ./Modes/ModeHeatDisinfect.c
    • -0
    • +2
    ./Services/SystemCommMessages.c
10:07 am

Dara Navaei

Done

Done

10:01 am

Dara Navaei

Done

Done

9:46 am

Dara Navaei

No this has been removed.

No this has been removed.

9:45 am

Dara Navaei

Removed the code.

Removed the code.

9:45 am

Dara Navaei

Removed the code.

Removed the code.

9:44 am

Dara Navaei

Removed the code.

Removed the code.

9:43 am

Dara Navaei

Done.

Done.

9:29 am

Sean Nash

Missing break?

Missing break?

9:22 am

Sean Nash

Shouldn't this just be an if (not an else if)? If both are unhealthy, we should activate both alarms, right?

Shouldn't this just be an if (not an else if)? If both are unhealthy, we should activate both alarms, right?

9:19 am

Sean Nash

Will this get picked up by doxygen? Do we want that? If not, maybe put this structure outside of the heat disinfect grouping.

Will this get picked up by doxygen? Do we want that? If not, maybe put this structure outside of the heat disinfect grouping.

9:15 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:14 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.