dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 01 Mar 2023
2:49 pm

Michael Garthwaite

DEN-14788: code review comments

Options
    • -1
    • +1
    ./Controllers/Heaters.c
2:33 pm

Dara Navaei

DEN-14834 updated the code to not check the rejection ratio and CPo if the target fill is less than 550 mL. Updated the heaters code to make sure the stop heaters command stops the heaters unless a new start command is issued

Options
    • -31
    • +39
    ./Controllers/Heaters.c
    • -11
    • +15
    ./Modes/ModeFill.c
1:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:10 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:10 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:09 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
10:00 am

Michael Garthwaite

Merge branch 'DEN-14689-messaging-bugs' into develop

Options
    • -1
    • +1
    ./Controllers/LoadCell.c
    • -4
    • +4
    ./Services/SystemComm.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
10:00 am

Michael Garthwaite

Merge branch 'staging' into DEN-14689-messaging-bugs

Options
    • -3
    • +3
    ./Services/SystemComm.c
    • -7
    • +2
    ./Services/SystemCommMessages.c
9:59 am

Michael Garthwaite

DEN-14689: message naming synchronization.

Options
    • -1
    • +1
    ./Controllers/FluidLeak.c
    • -1
    • +1
    ./Controllers/LoadCell.c
    • -1
    • +1
    ./Controllers/Valves.c
    • -1
    • +1
    ./Modes/ModeStandby.c
    • -1
    • +1
    ./Modes/OperationModes.c
    • -4
    • +4
    ./Services/SystemComm.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
9:53 am

Dara Navaei

DEN-14763 updated the cleaning modes

Options
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
Monday 27 Feb 2023
3:15 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
3:15 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    ./Modes/ModeFlush.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
3:15 pm

Dara Navaei

3:12 pm

wbracken  (deleted user) , Michael Garthwaite and Sean Nash

3:12 pm

dcox  (deleted user)

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

3:09 pm

dcox  (deleted user)

Remove old function call.

Remove old function call.

2:54 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:53 pm

Dara Navaei

DEN-14859 addressed a code review comment

Options
    • -1
    • +0
    ./Modes/ModeChemicalDisinfect.c
    • -2
    • +2
    ./Modes/ModeFlush.c
2:53 pm

Dara Navaei

Removed one. Thanks.

Removed one. Thanks.

2:07 pm

Michael Garthwaite

This variable is assigned twice in this init function

This variable is assigned twice in this init function

2:06 pm

Dara Navaei

DEN-14859 addressed a code review comment

Options
    • -2
    • +1
    ./Modes/ModeHeatDisinfect.c
2:06 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

2:05 pm

Dara Navaei

Removed the variables.

Removed the variables.

2:05 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

2:03 pm

Dara Navaei

I removed the variable from the documentation.

I removed the variable from the documentation.

2:01 pm

Michael Garthwaite

rsrvrFillStableTimeCounter is no longer used in getRsrvrDrainStatus()

rsrvrFillStableTimeCounter is no longer used in getRsrvrDrainStatus()

1:59 pm

Michael Garthwaite

targetDisinfectTime is only used in publishing. Documentation says its used in getHeatDisinfectStatus but its not used. Is it still needed?

targetDisinfectTime is only used in publishing. Documentation says its used in getHeatDisinfectStatus but its not used. Is it still needed?

1:52 pm

Dara Navaei

DEN-14859 updated the code

Options
    • -1
    • +1
    ./Modes/ModeFlush.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
1:42 pm

Dara Navaei

DG-DEN-14859_Cleaning Modes State Timer Reset
DG-DEN-14859_Cleaning Modes State Timer Reset