dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 07 Mar 2023
11:34 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/DrainPump.c
    • -2
    • +2
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Modes/ModeDrain.c
    • -1
    • +1
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Modes/ModeGenIdle.c
    • -1
    • +1
    ./Services/Reservoirs.c
    • -1
    • +1
    ./Services/Reservoirs.h
11:32 am

Dara Navaei

11:28 am

wbracken  (deleted user) and Sean Nash

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:18 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:15 am

Dara Navaei

In common.h to be used by both stacks.

In common.h to be used by both stacks.

11:15 am

Sean Nash

Where did this go?

Where did this go?

11:06 am

Dara Navaei

DEN-14834 updated the code to just send the heater command in Idle and Drain if the primary heater is not on. Addressed the code review comments

Options
    • -6
    • +6
    ./Controllers/Heaters.c
    • -2
    • +6
    ./Modes/ModeDrain.c
    • -2
    • +6
    ./Modes/ModeGenIdle.c
    • -4
    • +4
    ./Services/Reservoirs.c
    • -10
    • +0
    ./Services/Reservoirs.h
11:05 am

Dara Navaei

Done.

Done.

11:04 am

Dara Navaei

Done.

Done.

11:03 am

Dara Navaei

Done

Done

Monday 06 Mar 2023
5:10 pm

Sean Nash

Remove blank line.

Remove blank line.

5:07 pm

Sean Nash

Comments for these target flows should explain why they're here (instead of just getting flow from flow module).

Comments for these target flows should explain why they're here (instead of just getting flow from flow module).

4:49 pm

Sean Nash

What is the point of subtracting 0.0?

What is the point of subtracting 0.0?

4:01 pm

Dara Navaei

DG-DEN-14834_RO Flow Drops TO Zero And CP Measured Speed 1500 Temporarily During Pre Treatment
DG-DEN-14834_RO Flow Drops TO Zero And CP Measured Speed 1500 Temporarily During Pre Treatment
3:23 pm

Dara Navaei

Merge branch 'staging' into DEN-14834-ro-flow-drops-to-zero-and-cp-measured-speed-1500-temporarily-during-pre-treatment

Options
    • -2
    • +7
    ./Controllers/Heaters.c
2:50 pm

Dara Navaei

DEN-14834 updated that get target primary heater function to accomodate the changes from pre-treatment. Removed the range check from the drain pump measured RPM

Options
    • -10
    • +6
    ./Controllers/DrainPump.c
    • -15
    • +17
    ./Controllers/Heaters.c
    • -14
    • +17
    ./Controllers/TemperatureSensors.c
    • -29
    • +44
    ./Services/Reservoirs.c
    • -1
    • +1
    ./Services/Reservoirs.h
Friday 03 Mar 2023
2:47 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:34 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
2:34 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/Heaters.c
    • -2
    • +2
    ./Modes/ModeFlush.c
2:33 pm

Michael Garthwaite

2:32 pm

wbracken  (deleted user) and jtaylor  (deleted user)

Thursday 02 Mar 2023
10:29 am

Michael Garthwaite

I believe this MSG_ID is being removed in another branch

I believe this MSG_ID is being removed in another branch

10:28 am

Michael Garthwaite

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2 Ill reorganize ...

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2
Ill reorganize the review naming shortly.

10:21 am

Sean Nash

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

10:19 am

Sean Nash

Is this a response to request above or a data broadcast?

Is this a response to request above or a data broadcast?

10:18 am

Sean Nash

Should this have _REQUEST added to end?

Should this have _REQUEST added to end?