dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 14 Mar 2023
4:56 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Update per code review comments.

Options
    • -1
    • +1
    ./Controllers/Valves.c
1:47 pm

wbracken  (deleted user)

Corrected.

Corrected.

1:41 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Update per code review comments.

Options
    • -18
    • +5
    ./Controllers/ConductivitySensors.c
    • -2
    • +1
    ./Controllers/Heaters.c
    • -2
    • +2
    ./Controllers/TemperatureSensors.c
    • -2
    • +2
    ./Controllers/Voltages.h
    • -0
    • +6
    ./Services/FPGA.c
    • -1
    • +6
    ./Services/WatchdogMgmt.c
12:21 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:46 am

wbracken  (deleted user)

Corrected.

Corrected.

11:46 am

wbracken  (deleted user)

Correct as is per conversation with Darren.

Correct as is per conversation with Darren.

11:31 am

wbracken  (deleted user)

Removed.

Removed.

10:07 am

wbracken  (deleted user)

Yes.

Yes.

10:00 am

wbracken  (deleted user)

Per our alarms discussion it was decided that this alarm was no longer necessary.

Per our alarms discussion it was decided that this alarm was no longer necessary.

9:19 am

wbracken  (deleted user)

Add concCap and diaCap to header.

Add concCap and diaCap to header.

9:17 am

wbracken  (deleted user)

Function header.

Function header.

9:17 am

wbracken  (deleted user)

Function header.

Function header.

9:16 am

wbracken  (deleted user)

Function header.

Function header.

9:15 am

wbracken  (deleted user)

Function header.

Function header.

9:14 am

wbracken  (deleted user)

Function header.

Function header.

9:14 am

wbracken  (deleted user)

Function header.

Function header.

9:12 am

wbracken  (deleted user)

Add function header.

Add function header.

9:11 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Monday 13 Mar 2023
5:31 pm

Dara Navaei

DEN-14763 work in progress continued working on the heat disinfect active cool mode

Options
    • -91
    • +87
    ./Modes/ModeHeatDisinfectActiveCool.c
    • -0
    • +1
    ./Modes/ModeHeatDisinfectActiveCool.h
    • -9
    • +11
    ./Modes/ModeStandby.c
    • -1
    • +0
    ./Modes/ModeStandby.h
    • -4
    • +4
    ./Services/SystemCommMessages.c
5:06 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Correct inclusion of watchdog alarm. Remove alarm for checking for comm errors detected by the FPGA.

Options
    • -6
    • +0
    ./Services/FPGA.c
    • -2
    • +1
    ./Services/WatchdogMgmt.c
9:13 am

Sean Nash

DEBUG bread crumb comment?

DEBUG bread crumb comment?

9:12 am

Sean Nash

DEBUG bread crumb comment.

DEBUG bread crumb comment.

9:10 am

Sean Nash

Maybe we should put a bread crumb comment here to make it easier to find lines of code that need to be commented out when debugging (e.g. // comment this line for DEBUG).

Maybe we should put a bread crumb comment here to make it easier to find lines of code that need to be commented out when debugging (e.g. // comment this line for DEBUG).

9:06 am

Sean Nash

A small thing, but 24V Main should come before first voltage.

A small thing, but 24V Main should come before first voltage.

9:04 am

Sean Nash

Why is this indented?

Why is this indented?

9:02 am

Sean Nash

Is prefix guaranteed to not be zero?

Is prefix guaranteed to not be zero?

8:55 am

Sean Nash

Is it ok to ignore P if package has already been started? Should this ever happen?

Is it ok to ignore P if package has already been started? Should this ever happen?

8:54 am

Sean Nash

Use #define for bit mask. Remove extra ";".

Use #define for bit mask. Remove extra ";".

Friday 10 Mar 2023
2:16 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

# Conflicts:

# firmware/App/Controllers/TemperatureSensors.c

Options
    • -48
    • +63
    ./Controllers/Heaters.c
    • -1
    • +5
    ./Controllers/TemperatureSensors.c
1:44 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 - Remove code inserted for debugging. Enable FPGA clock speed check and watchdog check.

Options
    • -17
    • +1
    ./Controllers/ConductivitySensors.c
    • -1
    • +1
    ./Controllers/Voltages.c
    • -2
    • +3
    ./Controllers/Voltages.h
    • -38
    • +8
    ./Services/FPGA.c
    • -2
    • +0
    ./Services/WatchdogMgmt.c