dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 7
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Mar 2023
5:07 pm

Dara Navaei

DEN-15014 addressed the code review comment

Options
    • -1
    • +0
    ./Services/SystemCommMessages.c
5:03 pm

Sean Nash

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

5:00 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:59 pm

Dara Navaei

DEN-15014 addressed the code review comment

Options
    • -1
    • +1
    ./Controllers/ROPump.c
4:59 pm

Dara Navaei

Check the diff of the last two commits.

Check the diff of the last two commits.

4:58 pm

Sean Nash

What I meant is that we don't need to send anything other than response.

What I meant is that we don't need to send anything other than response.

4:58 pm

Dara Navaei

Done

Done

4:57 pm

Sean Nash

Remove TODO?

Remove TODO?

4:57 pm

Dara Navaei

DEN-15014 updated the fill mode by removing the enable RO only mode variable from the init function to not be set to FALSE every time

Options
    • -2
    • +3
    ./Modes/ModeFill.c
4:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:52 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:51 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:48 pm

Dara Navaei

DEN-15014 addressed the code review comments

Options
    • -1
    • +1
    ./Controllers/ConductivitySensors.c
    • -1
    • +1
    ./Controllers/ROPump.c
    • -7
    • +5
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Modes/ModeFill.h
    • -1
    • +1
    ./Services/SystemComm.c
    • -9
    • +7
    ./Services/SystemCommMessages.c
4:47 pm

Dara Navaei

Done

Done

4:43 pm

Dara Navaei

Changed it to TRUE/FALSE.

Changed it to TRUE/FALSE.

4:43 pm

Dara Navaei

Updated the code.

Updated the code.

4:42 pm

Dara Navaei

Done

Done

4:17 pm

Dara Navaei

Done

Done

4:17 pm

Dara Navaei

Done

Done

4:15 pm

Dara Navaei

Done

Done

4:13 pm

Dara Navaei

Done

Done

4:10 pm

Sean Nash

Prefer to say RO only != TRUE so that any other value than 1 will cause RR alarm to be enforced.

Prefer to say RO only != TRUE so that any other value than 1 will cause RR alarm to be enforced.

4:08 pm

Sean Nash

Needs param so caller can set it to FALSE too?

Needs param so caller can set it to FALSE too?

4:07 pm

Sean Nash

Doesn't look like this list is complete. In my opinion, init functions should be allowed to generalize here (e.g. Fill mode variables initialized.).

Doesn't look like this list is complete. In my opinion, init functions should be allowed to generalize here (e.g. Fill mode variables initialized.).

4:04 pm

Sean Nash

I don't think we need to ack/nak since we always respond with response msg.

I don't think we need to ack/nak since we always respond with response msg.