dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Mar 2023
3:34 pm

dcox  (deleted user)

3:32 pm

jtaylor  (deleted user) , dcox  (deleted user) and Sean Nash

3:18 pm

Michael Garthwaite

1:45 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:44 pm

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:43 pm

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:42 pm

wbracken  (deleted user)

Corrected

Corrected

1:42 pm

wbracken  (deleted user)

Corrected

Corrected

1:42 pm

wbracken  (deleted user)

Corrected

Corrected

1:21 pm

Michael Garthwaite and Sean Nash

1:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:03 pm

dcox  (deleted user)

Does TODO need to be resolved?

Does TODO need to be resolved?

1:01 pm

jtaylor  (deleted user)

Extra space before the last paren.

Extra space before the last paren.

12:59 pm

jtaylor  (deleted user)

Missing space.

Missing space.

12:53 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:48 pm

Michael Garthwaite

12:29 pm

jtaylor  (deleted user)

Done.

Done.

10:07 am

wbracken  (deleted user)

Space between ((

Space between ((

9:44 am

Sean Nash and wbracken  (deleted user)

9:14 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:03 am

Sean Nash

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

8:54 am

Michael Garthwaite

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

8:36 am

jtaylor  (deleted user)

Done. Does HD communicating always account for UI traffic as well?

Done. Does HD communicating always account for UI traffic as well?

8:35 am

jtaylor  (deleted user)

Done

Done

8:22 am

jtaylor  (deleted user)

Reverted.

Reverted.

Thursday 30 Mar 2023
7:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

6:58 pm

Sean Nash

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

6:57 pm

Sean Nash

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).